FixLoad loads helper functions, not just rules #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@illicitonion thanks for the great PR! Left one comment, but besides that the change LGTM. |
blico
reviewed
Jan 25, 2022
Some language implementations may try to add helper functions as `CallExpr`s, e.g. in rules_python the `requirement` function, or in rules_jvm_external the `artifact` function. This allows for parsing these out and adding `load` statements for them. See also: bazelbuild#981, bazelbuild#978, bazelbuild#1087
illicitonion
force-pushed
the
add-loads-for-helper-functions
branch
from
6160cf5
to
6e9b9c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What package or component does this PR mostly affect?
mergerWhat does this PR do? Why is it needed?
Some language implementations may try to add helper functions as
CallExprs, e.g. in rules_python therequirementfunction, or inrules_jvm_external the
artifactfunction. This allows for parsingthese out and adding
loadstatements for them.Which issues(s) does this PR fix?
See also: #981, #978, #1087 (but does not fully fix them).
Other notes for review
This approach was suggested in this comment.