[Extraction] prep for go.mod & go.work FilePath ReplaceDirective work #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
go-refactorings-for-file-path-replace-work
branch
7 times, most recently
from
e86b131
to
d87bdae
Compare
stefanpenner
changed the title
stefanpenner
force-pushed
the
go-refactorings-for-file-path-replace-work
branch
2 times, most recently
from
9ff1a3c
to
8e62680
Compare
10 tasks
fmeum
approved these changes
Apr 10, 2024
stefanpenner
force-pushed
the
go-refactorings-for-file-path-replace-work
branch
from
8e62680
to
d10e934
Compare
stefanpenner
force-pushed
the
go-refactorings-for-file-path-replace-work
branch
from
d10e934
to
d4627be
Compare
|
@fmeum updated based on your feedback & rebased. |
fmeum
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Extraction as per #1776 (comment)
What package or component does this PR mostly affect?
What does this PR do? Why is it needed?
Extraction to simplify #1776 and separated as it's own PR as per #1776 (comment)
Existing tests should cover this sufficiently.
Which issues(s) does this PR fix?
N/A
Other notes for review