Add support for include() in MODULE.bazel
#1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mortenmj Could you test this? |
|
Tested at Uber with Bazel 7.1.1 |
tyler-french
approved these changes
May 24, 2024
fmeum
force-pushed
the
1804-include
branch
2 times, most recently
from
1a9cb50
to
f6e41bf
Compare
Previously, `gazelle` wouldn't look into `include`ed segments of module files when collecting the apparent to module name mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
cmd/gazelle
What does this PR do? Why is it needed?
Previously,
gazellewouldn't look intoincludeed segments of module files when collecting the apparent to module name mapping.Which issues(s) does this PR fix?
Fixes #1804
Other notes for review