Detect BUILD files after fetching the repo #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test wether there were build files in a go_repository were done before actually fetching it, making gazelle always generate BUILD files, instead of doing it automatically. This fixes build_file_generation="auto". Signed-off-by: Steeve Morin <steeve@zen.ly>
jayconrod
approved these changes
Jun 4, 2019
steeve
commented
Jun 5, 2019
| path = ctx.path(name) | ||
| if path.exists and not env_execute(ctx, ["test", "-f", path]).return_code: | ||
| generate = False | ||
| break | ||
| if fetch_repo_args or generate: |
There was a problem hiding this comment.
Actually, generate should be removed! I'll do separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test wether there were build files in a go_repository were done
before actually fetching it, making gazelle always generate BUILD files,
instead of doing it automatically.
This fixes build_file_generation="auto".