Remove --experimental_build_setting_api usage #249
Conversation
Deprecating this flag so removing all usage.
juliexxia
requested review from
aiuto,
c-parsons,
jin and
laurentlb
as code owners
|
Hm, "rules/common_settings.bzl:91:18: parameter 'build_setting' is experimental and thus unavailable with the current flags. It may be enabled by setting --experimental_build_setting_api" even though --experimental_build_setting_api is set to true by default (and has been for some while) |
|
I have to say I am baffled. You are removing the flag, and yet the stuff
complains about using it.
How about a CL which just does tests/common_settings_test.sh alone.
If that works, then cut it from the rule in a second pass.
…On Thu, May 21, 2020 at 4:26 PM Julie ***@***.***> wrote:
Hm, "rules/common_settings.bzl:91:18: parameter 'build_setting' is
experimental and thus unavailable with the current flags. It may be enabled
by setting --experimental_build_setting_api" even though
--experimental_build_setting_api is set to true by default (and has been
for some while)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#249 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHBFBARRMRDZGTBCADLRSWFA5ANCNFSM4NHEHI5Q>
.
|
|
any luck with the tests? |
|
Yep, but now getting a bunch of buildifer errors from unrelated tests...investigating... |
|
The buildifier failures started happening after the CI started to use Buildifier 3.0.0, from 2.2.1 At commit 560d7b2: 2.2.1, buildifier passes: https://buildkite.com/bazel/bazel-skylib/builds/986#b171ed75-253b-4e14-8e0e-47d84c5ca20a |
|
Yeah I realized that as well - @vladmos did you ever get a chance to take a look at these failures? |
|
There were newly discovered bugs in the version of buildifier I wanted to release last week, I'll make a new release that will make most of the findings disappear early next week. The rest of the warnings can be temporarily disabled by special comments to unblock pull requests. |
|
Looks like buildifer issues got fixed thanks @vladmos ! Could a reviewer take a look now? Thanks! |
Deprecating this flag so removing all usage.