Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose int- and string-valued build settings as Make variables #440

Merged
merged 2 commits into from
Aug 22, 2023

Commits on Mar 24, 2023

  1. Expose int- and string-valued build settings as Make variables

    While build settings allow for much cleaner flag and setting definitions
    than `--define`, they have the major drawback that rules need to provide
    dedicated support for them, which isn't the case for native and most
    community-maintained rules.
    
    This change attempts to bridge this gap by optionally exposing the value
    of the common build setting types as Make variables to rules that depend
    on them via the `toolchains` attribute: If the new `make_variable`
    attribute is set, the value of the flag or setting is available as a
    Make variable with that.
    
    Consistency with pre-defined Make variables is enforced by limiting the
    character set for `make_variable` values to `[A-Z0-9_]`. The new
    attribute is also only added to int- and string-valued build settings as
    the other types lack a canonical stringification.
    fmeum committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    6802da8 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Configuration menu
    Copy the full SHA
    0be9ad8 View commit details
    Browse the repository at this point in the history