Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not test with --all_incompatible_changes #202

Closed
hlopko opened this issue Oct 16, 2018 · 1 comment
Closed

Do not test with --all_incompatible_changes #202

hlopko opened this issue Oct 16, 2018 · 1 comment

Comments

@hlopko
Copy link
Member

hlopko commented Oct 16, 2018

In #198 I discovered that there are tests run with --all_incompatible_changes.

That is not a great idea, it assumes that bazel codebase itself is fixed the moment a new incompatible flag is introduced, which is something we don't enforce with our of tests. Can we have 2 separate tests, one with --all_incompatible_changes, that will be run on https://buildkite.com/bazel/bazel-toolchains, and one without, that will be run as part of bazel with downstream projects pipeline (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel).

It's fine to break the first one (we consider it your responsibility to monitor and fix failures there), but we don't want the second to be red (as we consider it our responsibility to keep it green).

Thanks!

@xingao267
Copy link
Member

xingao267 commented Oct 17, 2018

IIUC, this is no longer applicable I guess. In the tests, we do not use --all_incompatible_changes to build the bazel codebase itself. We use --all_incompatible_changes to run bazel build ----all_incompatible_changes @local_config_cc/... in a very simple cc project which does not contain any incompatible changes.

Please reopen if it's not the case.

nlopezgi added a commit that referenced this issue Oct 22, 2018
turn tests with bazel head on again:
Fixes #202
Issue was fixed with bazelbuild/bazel@6bc4528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants