You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #198 I discovered that there are tests run with --all_incompatible_changes.
That is not a great idea, it assumes that bazel codebase itself is fixed the moment a new incompatible flag is introduced, which is something we don't enforce with our of tests. Can we have 2 separate tests, one with --all_incompatible_changes, that will be run on https://buildkite.com/bazel/bazel-toolchains, and one without, that will be run as part of bazel with downstream projects pipeline (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel).
It's fine to break the first one (we consider it your responsibility to monitor and fix failures there), but we don't want the second to be red (as we consider it our responsibility to keep it green).
Thanks!
The text was updated successfully, but these errors were encountered:
IIUC, this is no longer applicable I guess. In the tests, we do not use --all_incompatible_changes to build the bazel codebase itself. We use --all_incompatible_changes to run bazel build ----all_incompatible_changes @local_config_cc/... in a very simple cc project which does not contain any incompatible changes.
In #198 I discovered that there are tests run with --all_incompatible_changes.
That is not a great idea, it assumes that bazel codebase itself is fixed the moment a new incompatible flag is introduced, which is something we don't enforce with our of tests. Can we have 2 separate tests, one with --all_incompatible_changes, that will be run on https://buildkite.com/bazel/bazel-toolchains, and one without, that will be run as part of bazel with downstream projects pipeline (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel).
It's fine to break the first one (we consider it your responsibility to monitor and fix failures there), but we don't want the second to be red (as we consider it our responsibility to keep it green).
Thanks!
The text was updated successfully, but these errors were encountered: