Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow using CROSSTOOL to select the cc_toolchain label #216

Closed
hlopko opened this issue Oct 25, 2018 · 8 comments
Closed

Disallow using CROSSTOOL to select the cc_toolchain label #216

hlopko opened this issue Oct 25, 2018 · 8 comments
Assignees
@xingao267

Comments

@hlopko
Copy link
Member

hlopko commented Oct 25, 2018

Hello :)

I'm back again, I promise this is the last time. Today the incompatible flag for bazelbuild/bazel#6382 has been flipped, and it affects the bazel toolchains (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/539#9c3cb2d3-791d-4e1f-944d-f768fb2810be). Please see migration docs here: https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disallow-using-crosstool-to-select-the-cc_toolchain-label, and let me know if you have problems.

Extra points for also updating bazel-toolchains versions in rules_go, rules_rust, rules_kotlin, and rules_scala, but I can also do that.

Please create an issue at https://github.com/bazelbuild/continuous-integration to reenable bazel-toolchains on the downstream pipeline.
hlopko added a commit to bazelbuild/continuous-integration that referenced this issue Oct 25, 2018
@hlopko
Disable bazel-toolchains and its users
751a143 
Reenable once bazelbuild/bazel-toolchains#216 is fixed and users are updated
@xingao267
Copy link
Member

Working on this.

@xingao267 xingao267 self-assigned this Oct 25, 2018
@hlopko
Copy link
Member Author

hlopko commented Oct 25, 2018

You're amazing Xin! Thank you!

@xingao267
Copy link
Member

Ok. This is a little more complicated than I initially thought. The reason why it is failing is because the buildkite CI is using old toolchain configs (0.16.1), and those are not compatible with bazel head. So the fix would be I'll first update all bazel rule repos' WORKSPACE pin of bazel_toolchains to our latest, which will include our latest toolchain configs for Bazel 0.18.0. Then I'll update the toolchain flags in Buildkite CI.

@hlopko
Copy link
Member Author

hlopko commented Oct 25, 2018

And by all rules you mean rules_go, rules_rust, rules_kotlin, and rules_scala, right? Because others were not failing?

@xingao267
Copy link
Member

Yes. All the rules that enabled rbe_ubuntu1604 platform in their buildkite ci.

@xingao267
Copy link
Member

xingao267 commented Oct 25, 2018 •
edited
Loading

I'm creating a PR in bazel-toolchains repo first to add a latest alias to crosstool and toolchain targets, so we don't need to modify buildkite configs in the future again (in most cases).

@xingao267 xingao267 mentioned this issue Oct 26, 2018
Merged
xingao267 added a commit to xingao267/rules_docker that referenced this issue Oct 26, 2018
@xingao267
Update bazel_toolchains pin.
a58d139 
bazelbuild/bazel-toolchains#216
xingao267 added a commit to xingao267/rules_go that referenced this issue Oct 26, 2018
@xingao267
Update bazel_toolchains pin.
0471ff8 
bazelbuild/bazel-toolchains#216
@xingao267 xingao267 mentioned this issue Oct 26, 2018
Merged
xingao267 added a commit to xingao267/rules_groovy that referenced this issue Oct 26, 2018
@xingao267
Update bazel_toolchains pin.
5c52077 
bazelbuild/bazel-toolchains#216
@xingao267 xingao267 mentioned this issue Oct 26, 2018
Merged
xingao267 added a commit to xingao267/rules_scala that referenced this issue Oct 26, 2018
@xingao267
Update bazel-toolchains pin.
07d6e99 
bazelbuild/bazel-toolchains#216
@xingao267 xingao267 mentioned this issue Oct 26, 2018
Merged
xingao267 added a commit to xingao267/rules_nodejs that referenced this issue Oct 26, 2018
@xingao267
Update bazel_toolchains pin.
c516d58 
bazelbuild/bazel-toolchains#216
@xingao267 xingao267 mentioned this issue Oct 26, 2018
Merged
xingao267 added a commit to xingao267/rules_kotlin that referenced this issue Oct 26, 2018
@xingao267
Update bazel_toolchains pin.
164c219 
bazelbuild/bazel-toolchains#216
@xingao267 xingao267 mentioned this issue Oct 26, 2018
Merged
xingao267 added a commit to bazelbuild/rules_docker that referenced this issue Oct 26, 2018
@xingao267
Update bazel_toolchains pin. (#561)
a9bb1da 
bazelbuild/bazel-toolchains#216
nlopezgi pushed a commit to bazelbuild/rules_kotlin that referenced this issue Oct 26, 2018
@xingao267 @nlopezgi
Update bazel_toolchains pin. (#157)
87bd13f 
bazelbuild/bazel-toolchains#216
hlopko pushed a commit to bazelbuild/rules_rust that referenced this issue Oct 26, 2018
@xingao267 @hlopko
Update bazel_toolchains pin. (#147)
4a9d0e0 
bazelbuild/bazel-toolchains#216
jayconrod pushed a commit to bazelbuild/rules_go that referenced this issue Oct 26, 2018
@xingao267 @jayconrod
Update bazel_toolchains pin. (#1793)
70ae140 
bazelbuild/bazel-toolchains#216
ittaiz pushed a commit to bazelbuild/rules_scala that referenced this issue Oct 26, 2018
@xingao267 @ittaiz
Update bazel-toolchains pin. (#636)
f3c127a 
bazelbuild/bazel-toolchains#216
xingao267 added a commit to xingao267/continuous-integration that referenced this issue Oct 26, 2018
@xingao267
Update RBE toolchain flags.
c7ba4bc 
Do not submit until all PRs to update @bazel_toolchains WORKSPACE pin
are merged.

bazelbuild/bazel-toolchains#216
xingao267 added a commit to xingao267/continuous-integration that referenced this issue Oct 26, 2018
@xingao267
Update RBE toolchain flags.
b6e7fcf 
Do not submit until all PRs to update @bazel_toolchains WORKSPACE pin
are merged.

bazelbuild/bazel-toolchains#216
bazelbuild#319
ekuefler pushed a commit to bazelbuild/rules_groovy that referenced this issue Oct 27, 2018
@xingao267 @ekuefler
Update bazel_toolchains pin. (#21)
b20234c 
bazelbuild/bazel-toolchains#216
xingao267 added a commit to xingao267/continuous-integration that referenced this issue Oct 29, 2018
@xingao267
Update RBE toolchain flags.
75e1d16 
Do not submit until all PRs to update @bazel_toolchains WORKSPACE pin
are merged.

bazelbuild/bazel-toolchains#216
bazelbuild#319
@xingao267 xingao267 mentioned this issue Oct 29, 2018
Merged
alexeagle pushed a commit to bazelbuild/rules_nodejs that referenced this issue Nov 1, 2018
@xingao267 @alexeagle
Update bazel_toolchains pin.
aa7b3b6 
bazelbuild/bazel-toolchains#216
philwo pushed a commit to bazelbuild/continuous-integration that referenced this issue Nov 7, 2018
@xingao267 @philwo
Update RBE toolchain flags. (#364)
db02c01 
Do not submit until all PRs to update @bazel_toolchains WORKSPACE pin
are merged.

bazelbuild/bazel-toolchains#216
#319
@hlopko
Copy link
Member Author

hlopko commented Nov 27, 2018

Can this be closed now?

@nlopezgi
Copy link
Contributor

afaik yes, please reopen if there are any issues related to this still pending.

joeleba pushed a commit to joeleba/continuous-integration that referenced this issue Jun 17, 2019
@hlopko @joeleba
Disable bazel-toolchains and its users
67d9140 
Reenable once bazelbuild/bazel-toolchains#216 is fixed and users are updated
joeleba pushed a commit to joeleba/continuous-integration that referenced this issue Jun 17, 2019
@xingao267 @joeleba
Update RBE toolchain flags. (bazelbuild#364)
3370919 
Do not submit until all PRs to update @bazel_toolchains WORKSPACE pin
are merged.

bazelbuild/bazel-toolchains#216
bazelbuild#319
jongerrish added a commit to jongerrish/rules_kotlin that referenced this issue Apr 16, 2020
@jongerrish @nlopezgi
Update bazel_toolchains pin. (bazelbuild#157)
0fb3950 
bazelbuild/bazel-toolchains#216
richmowd411 added a commit to richmowd411/Rules-Kotlin that referenced this issue Apr 12, 2022
@richmowd411
Update bazel_toolchains pin. (#157)
892e5b2 
bazelbuild/bazel-toolchains#216
freeformstu pushed a commit to freeformstu/bazel-toolchains that referenced this issue Nov 11, 2023
@siddharthab
Misc cleanups (bazelbuild#216)
bb94933 
- Prepare for BCR release as 0.10.0
- Rename repo name to toolchains_llvm
- Upgrade Go version in tests and remove -nopie flag
- Combine lint and tests workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xingao267 xingao267

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hlopko @nlopezgi @xingao267