Skip to content

Commit 05787f3

Browse files
thiicopybara-github
authored andcommitted
Flip --experimental_cc_implementation_deps
This allows distributing libraries as source that use `implementation_deps`. Closes #19724. PiperOrigin-RevId: 571105562 Change-Id: I268c5aa0fd83b220aa85dbeb6eef6a07f6b7d3f7
1 parent 5807c59 commit 05787f3

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1031,7 +1031,7 @@ public Label getMemProfProfileLabel() {
10311031

10321032
@Option(
10331033
name = "experimental_cc_implementation_deps",
1034-
defaultValue = "false",
1034+
defaultValue = "true",
10351035
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
10361036
effectTags = {
10371037
OptionEffectTag.LOADING_AND_ANALYSIS,

src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2061,7 +2061,7 @@ public void testImplementationDepsConfigurationHostSucceeds() throws Exception {
20612061
}
20622062

20632063
@Test
2064-
public void testImplementationDepsFailsWithoutFlag() throws Exception {
2064+
public void testImplementationDepsSucceedsWithoutFlag() throws Exception {
20652065
if (!analysisMock.isThisBazel()) {
20662066
return;
20672067
}
@@ -2077,9 +2077,9 @@ public void testImplementationDepsFailsWithoutFlag() throws Exception {
20772077
" srcs = ['implementation_dep.cc'],",
20782078
" hdrs = ['implementation_dep.h'],",
20792079
")");
2080-
reporter.removeHandler(failFastHandler);
2081-
getConfiguredTarget("//foo:lib");
2082-
assertContainsEvent("requires --experimental_cc_implementation_deps");
2080+
assertThat(getConfiguredTarget("//foo:lib")).isNotNull();
2081+
;
2082+
assertDoesNotContainEvent("requires --experimental_cc_implementation_deps");
20832083
}
20842084

20852085
@Test

0 commit comments

Comments
 (0)