Skip to content

Commit

Permalink
Document @ as allowed in a package name
Browse files Browse the repository at this point in the history
Empirically, this works, and some rulesets (e.g. `rules_nodejs`)
explicitly create packages whose names contain `@` characters.

We should document this reality (or forbid it, but that would be a
massively breaking change to the ecosystem).

Additional context: https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1651850227929389?thread_ts=1651832164.144609&cid=CEZUUKQ6P

Closes #15428.

PiperOrigin-RevId: 448469769
  • Loading branch information
illicitonion authored and Copybara-Service committed May 13, 2022
1 parent 2432948 commit 1941dc1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions site/en/concepts/labels.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ relative to the top-level directory of the containing repository.
For example: `my/app`.

Package names must be composed entirely of characters drawn from the set
`A`-`Z`, `a``z`, `0``9`, '`/`', '`-`', '`.`', and '`_`', and cannot start
with a slash.
`A`-`Z`, `a``z`, `0``9`, '`/`', '`-`', '`.`', '`@`', and '`_`', and cannot
start with a slash.

For a language with a directory structure that is significant to its module
system (for example, Java), it's important to choose directory names that are
Expand Down

0 comments on commit 1941dc1

Please sign in to comment.