Address review comments

bazelbuild · Nov 9, 2023 · 406a2b7 · 406a2b7
1 parent 1df0f97
commit 406a2b7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaCompileAction.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaCompileAction.java
@@ -489,7 +489,7 @@ public ActionResult execute(ActionExecutionContext actionExecutionContext)
           .insertDependencies(
               outputDepsProto,
               readFullOutputDeps(fallbackResults, actionExecutionContext, spawn.getPathMapper()));
-    } else if (!spawn.getPathMapper().isNoop()){
+    } else if (!spawn.getPathMapper().isNoop()) {
       // As a side effect, readFullOutputDeps rewrites the on-disk .jdeps file from mapped to
       // unmapped paths. To make path mapping fully transparent to consumers of this action's
       // output, we ensure that the file always contains unmapped paths.

diff --git a/src/test/shell/bazel/path_mapping_test.sh b/src/test/shell/bazel/path_mapping_test.sh
@@ -214,7 +214,6 @@ bazelcon_greeting = rule(
     _bazelcon_greeting_impl,
     cfg = _location_transition,
     attrs = {
-        "_allowlist_function_transition": attr.label(default = "@bazel_tools//tools/allowlists/function_transition_allowlist"),
         "location": attr.string(),
     },
 )