-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Factor out unit tests common to py_binary, py_test, and py_library
The moved tests used to cover binary/test and now also cover library. Also added some test cases for srcs_version. Work toward #1446. RELNOTES: None PiperOrigin-RevId: 212999264
- Loading branch information
Showing
5 changed files
with
195 additions
and
110 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
122 changes: 122 additions & 0 deletions
122
src/test/java/com/google/devtools/build/lib/rules/python/PyBaseConfiguredTargetTestBase.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| // Copyright 2018 The Bazel Authors. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.devtools.build.lib.rules.python; | ||
|
|
||
| import static com.google.common.truth.Truth.assertThat; | ||
|
|
||
| import com.google.devtools.build.lib.analysis.ConfiguredTarget; | ||
| import com.google.devtools.build.lib.analysis.util.BuildViewTestCase; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
|
|
||
| /** Tests that are common to {@code py_binary}, {@code py_test}, and {@code py_library}. */ | ||
| public abstract class PyBaseConfiguredTargetTestBase extends BuildViewTestCase { | ||
|
|
||
| private final String ruleName; | ||
|
|
||
| protected PyBaseConfiguredTargetTestBase(String ruleName) { | ||
| this.ruleName = ruleName; | ||
| } | ||
|
|
||
| @Before | ||
| public final void setUpPython() throws Exception { | ||
| analysisMock.pySupport().setup(mockToolsConfig); | ||
| } | ||
|
|
||
| protected PythonVersion getPythonVersion(ConfiguredTarget ct) { | ||
| return getConfiguration(ct).getOptions().get(PythonOptions.class).getPythonVersion(); | ||
| } | ||
|
|
||
| @Test | ||
| public void badSrcsVersionValue() throws Exception { | ||
| checkError("pkg", "foo", | ||
| // error: | ||
| "invalid value in 'srcs_version' attribute: " | ||
| + "has to be one of 'PY2', 'PY3', 'PY2AND3', 'PY2ONLY' " | ||
| + "or 'PY3ONLY' instead of 'doesnotexist'", | ||
| // build file: | ||
| ruleName + "(", | ||
| " name = 'foo',", | ||
| " srcs_version = 'doesnotexist',", | ||
| " srcs = ['foo.py'])"); | ||
| } | ||
|
|
||
| @Test | ||
| public void goodSrcsVersionValue() throws Exception { | ||
| scratch.file("pkg/BUILD", | ||
| ruleName + "(", | ||
| " name = 'foo',", | ||
| " srcs_version = 'PY2',", | ||
| " srcs = ['foo.py'])"); | ||
| getConfiguredTarget("//pkg:foo"); | ||
| assertNoEvents(); | ||
| } | ||
|
|
||
| @Test | ||
| public void srcsVersionClashesWithForcePythonFlag() throws Exception { | ||
| useConfiguration("--force_python=PY3"); | ||
| checkError("pkg", "foo", | ||
| // error: | ||
| "'//pkg:foo' can only be used with Python 2", | ||
| // build file: | ||
| ruleName + "(", | ||
| " name = 'foo',", | ||
| " srcs = [':foo.py'],", | ||
| " srcs_version = 'PY2ONLY')"); | ||
| } | ||
|
|
||
| @Test | ||
| public void versionIs2IfUnspecified() throws Exception { | ||
| scratch.file("pkg/BUILD", | ||
| ruleName + "(", | ||
| " name = 'foo',", | ||
| " srcs = ['foo.py'])"); | ||
| assertThat(getPythonVersion(getConfiguredTarget("//pkg:foo"))).isEqualTo(PythonVersion.PY2); | ||
| } | ||
|
|
||
| @Test | ||
| public void versionIs3IfForcedByFlag() throws Exception { | ||
| useConfiguration("--force_python=PY3"); | ||
| scratch.file("pkg/BUILD", | ||
| ruleName + "(", | ||
| " name = 'foo',", | ||
| " srcs = ['foo.py'])"); | ||
| assertThat(getPythonVersion(getConfiguredTarget("//pkg:foo"))).isEqualTo(PythonVersion.PY3); | ||
| } | ||
|
|
||
| @Test | ||
| public void packageNameCannotHaveHyphen() throws Exception { | ||
| checkError("pkg-hyphenated", "foo", | ||
| // error: | ||
| "paths to Python packages may not contain '-'", | ||
| // build file: | ||
| ruleName + "(", | ||
| " name = 'foo',", | ||
| " srcs = ['foo.py'])"); | ||
| } | ||
|
|
||
| @Test | ||
| public void srcsPackageNameCannotHaveHyphen() throws Exception { | ||
| scratch.file("pkg-hyphenated/BUILD", | ||
| "exports_files(['bar.py'])"); | ||
| checkError("otherpkg", "foo", | ||
| // error: | ||
| "paths to Python packages may not contain '-'", | ||
| // build file: | ||
| ruleName + "(", | ||
| " name = 'foo',", | ||
| " srcs = ['foo.py', '//pkg-hyphenated:bar.py'])"); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.