Skip to content

Commit 92e16da

Browse files
lberkicopybara-github
authored andcommitted
Remove the command line flag --experimental_cc_shared_library_debug.
RELNOTES[INC]: The --experimental_cc_shared_library_debug command line flag is not available anymore. PiperOrigin-RevId: 568537101 Change-Id: Ibbaf21cd9337b00b339f52eec78c0346354ab464
1 parent 6b2ff30 commit 92e16da

File tree

4 files changed

+1
-30
lines changed

4 files changed

+1
-30
lines changed

src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -478,10 +478,6 @@ public boolean experimentalLinkStaticLibrariesOnce() {
478478
return cppOptions.experimentalLinkStaticLibrariesOnce;
479479
}
480480

481-
public boolean experimentalCcSharedLibraryDebug() {
482-
return cppOptions.experimentalCcSharedLibraryDebug;
483-
}
484-
485481
public boolean experimentalPlatformCcTest() {
486482
return cppOptions.experimentalPlatformCcTest;
487483
}
@@ -934,12 +930,6 @@ public boolean getExperimentalLinkStaticLibrariesOnce(StarlarkThread thread)
934930
return experimentalLinkStaticLibrariesOnce();
935931
}
936932

937-
@Override
938-
public boolean getExperimentalCcSharedLibraryDebug(StarlarkThread thread) throws EvalException {
939-
CcModule.checkPrivateStarlarkificationAllowlist(thread);
940-
return experimentalCcSharedLibraryDebug();
941-
}
942-
943933
@Override
944934
public boolean getExperimentalPlatformCcTest(StarlarkThread thread) throws EvalException {
945935
CcModule.checkPrivateStarlarkificationAllowlist(thread);

src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1134,17 +1134,6 @@ public Label getMemProfProfileLabel() {
11341134
+ " should only be linked once.")
11351135
public boolean experimentalLinkStaticLibrariesOnce;
11361136

1137-
@Option(
1138-
name = "experimental_cc_shared_library_debug",
1139-
defaultValue = "false",
1140-
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
1141-
effectTags = {
1142-
OptionEffectTag.LOADING_AND_ANALYSIS,
1143-
},
1144-
metadataTags = {OptionMetadataTag.EXPERIMENTAL},
1145-
help = "If enabled, will create debug files associated with cc_shared_library.")
1146-
public boolean experimentalCcSharedLibraryDebug;
1147-
11481137
@Option(
11491138
name = "experimental_cpp_compile_resource_estimation",
11501139
defaultValue = "false",
@@ -1233,7 +1222,6 @@ public FragmentOptions getExec() {
12331222
cxxoptListBuilder.add("-g0");
12341223
}
12351224
exec.experimentalLinkStaticLibrariesOnce = experimentalLinkStaticLibrariesOnce;
1236-
exec.experimentalCcSharedLibraryDebug = experimentalCcSharedLibraryDebug;
12371225
exec.experimentalCcImplementationDeps = experimentalCcImplementationDeps;
12381226

12391227
exec.coptList = coptListBuilder.addAll(hostCoptList).build();

src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/CppConfigurationApi.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,7 @@ public interface CppConfigurationApi<InvalidConfigurationExceptionT extends Exce
3838
documented = false,
3939
useStarlarkThread = true)
4040
boolean getExperimentalLinkStaticLibrariesOnce(StarlarkThread thread) throws EvalException;
41-
42-
@StarlarkMethod(
43-
name = "experimental_cc_shared_library_debug",
44-
documented = false,
45-
useStarlarkThread = true)
46-
boolean getExperimentalCcSharedLibraryDebug(StarlarkThread thread) throws EvalException;
47-
41+
4842
@StarlarkMethod(
4943
name = "experimental_platform_cc_test",
5044
documented = false,

src/main/starlark/tests/builtins_bzl/cc_builtin_tests.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ EOF
6969
fi
7070

7171
bazel $START_OPTS test --define=is_bazel=true --test_output=streamed \
72-
--experimental_cc_shared_library_debug \
7372
//src/main/starlark/tests/builtins_bzl/cc/... || fail "expected success"
7473
}
7574

0 commit comments

Comments
 (0)