delete incompatible_use_platforms_repo_for_constraints

Fixes #16330

PiperOrigin-RevId: 560730031
Change-Id: I9eb2465559811dd9186940991105dcee202550cc

scripts/bootstrap/compile.sh

@@ -304,10 +304,6 @@ EOF
   link_children "${PWD}" tools/python "${BAZEL_TOOLS_REPO}"
   link_children "${PWD}" tools "${BAZEL_TOOLS_REPO}"
 
-  # Set up @bazel_tools//platforms properly
-  mkdir -p ${BAZEL_TOOLS_REPO}/platforms
-  cp tools/platforms/BUILD.tools ${BAZEL_TOOLS_REPO}/platforms/BUILD
-
   # Set up @maven properly
   cp maven/BUILD.vendor maven/BUILD
 

src/create_embedded_tools.py

@@ -33,7 +33,6 @@
     ('*tools/build_defs/repo/BUILD.repo',
      lambda x: 'tools/build_defs/repo/BUILD'),
     ('*tools/j2objc/BUILD.tools', lambda x: 'tools/j2objc/BUILD'),
-    ('*tools/platforms/BUILD.tools', lambda x: 'platforms/BUILD'),
     ('*tools/platforms/*', lambda x: 'platforms/' + os.path.basename(x)),
     ('*tools/cpp/BUILD.tools', lambda x: 'tools/cpp/BUILD'),
     ('*tools/cpp/runfiles/generated_*',

src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRulesModule.java

@@ -61,15 +61,6 @@ public static class BuildGraveyardOptions extends OptionsBase {
         help = "Deprecated. No-op.")
     public boolean skyframePrepareAnalysis;
 
-    @Option(
-        name = "incompatible_use_platforms_repo_for_constraints",
-        defaultValue = "true",
-        documentationCategory = OptionDocumentationCategory.OUTPUT_PARAMETERS,
-        effectTags = {OptionEffectTag.AFFECTS_OUTPUTS},
-        metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
-        help = "Deprecated no-op.")
-    public boolean usePlatformsRepoForConstraints;
-
     @Option(
         name = "experimental_replay_action_out_err",
         defaultValue = "false",

src/test/shell/bazel/platforms_test.sh

@@ -73,39 +73,6 @@ EOF
     fail "Bazel failed to build @platforms"
 }
 
-function test_incompatible_use_platforms_repo_for_constraints() {
-  # We test that a built-in @platforms repository is buildable.
-  bazel build --incompatible_use_platforms_repo_for_constraints @bazel_tools//platforms:all &> \
-    $TEST_log && fail "Build passed when we expected an error."
-  expect_log "Constraints from @bazel_tools//platforms have been removed."
-}
-
-function test_incompatible_use_platforms_repo_for_constraints_exec() {
-  # We test that a built-in @platforms repository is buildable.
-  cat > BUILD << 'EOF'
-genrule(
-    name = "hello",
-    outs = ["hello.txt"],
-    cmd = "echo 'Hello' > $@",
-    tools = ["tool"],
-)
-
-genrule(
-    name = "tool",
-    outs = ["tool.sh"],
-    cmd = "touch $@",
-    target_compatible_with = select({
-        "@bazel_tools//platforms:linux": [],
-        "//conditions:default": [],
-    })
-)
-EOF
-
-  bazel build //:all &> \
-    $TEST_log && fail "Build passed when we expected an error."
-  expect_log "Constraints from @bazel_tools//platforms have been removed."
-}
-
 function test_platform_accessor() {
   cat > rules.bzl <<'EOF'
 def _impl(ctx):

tools/BUILD

@@ -24,7 +24,6 @@ filegroup(
         "//tools/mini_tar:srcs",
         "//tools/objc:srcs",
         "//tools/osx:srcs",
-        "//tools/platforms:srcs",
         "//tools/proto:srcs",
         "//tools/python:srcs",
         "//tools/runfiles:srcs",
@@ -59,7 +58,6 @@ filegroup(
         "//tools/launcher:srcs",
         "//tools/objc:srcs",
         "//tools/osx:srcs",
-        "//tools/platforms:srcs",
         "//tools/proto:srcs",
         "//tools/python:embedded_tools",
         "//tools/runfiles:embedded_tools",