Remove the --experimental_analysis_test_call command line option.

RELNOTES[INC]: testing.analysis_test is not experimental anymore PiperOrigin-RevId: 568547119 Change-Id: Ib9d5c543f33cf73f6c681a2c45f2fd7e47774a85
bazelbuild · Sep 26, 2023 · b747a4f · b747a4f
1 parent 480c8c8
commit b747a4f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 16 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java b/src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java
@@ -370,17 +370,6 @@ public final class BuildLanguageOptions extends OptionsBase {
               + " parameter for deferred evaluation of substitution values.")
   public boolean experimentalLazyTemplateExpansion;
 
-  @Option(
-      name = "experimental_analysis_test_call",
-      defaultValue = "true",
-      documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
-      effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS, OptionEffectTag.BUILD_FILE_SEMANTICS},
-      metadataTags = {
-        OptionMetadataTag.EXPERIMENTAL,
-      },
-      help = "If set to true, analysis_test native call is available.")
-  public boolean experimentalAnalysisTestCall;
-
   @Option(
       name = "incompatible_struct_has_no_methods",
       defaultValue = "false",
@@ -759,7 +748,6 @@ public StarlarkSemantics toStarlarkSemantics() {
                 INCOMPATIBLE_EXISTING_RULES_IMMUTABLE_VIEW, incompatibleExistingRulesImmutableView)
             .setBool(EXPERIMENTAL_ACTION_RESOURCE_SET, experimentalActionResourceSet)
             .setBool(EXPERIMENTAL_LAZY_TEMPLATE_EXPANSION, experimentalLazyTemplateExpansion)
-            .setBool(EXPERIMENTAL_ANALYSIS_TEST_CALL, experimentalAnalysisTestCall)
             .setBool(EXPERIMENTAL_GOOGLE_LEGACY_API, experimentalGoogleLegacyApi)
             .setBool(EXPERIMENTAL_PLATFORMS_API, experimentalPlatformsApi)
             .setBool(EXPERIMENTAL_CC_SHARED_LIBRARY, experimentalCcSharedLibrary)
@@ -870,7 +858,6 @@ public StarlarkSemantics toStarlarkSemantics() {
   public static final String EXPERIMENTAL_ACTION_RESOURCE_SET = "+experimental_action_resource_set";
   public static final String EXPERIMENTAL_LAZY_TEMPLATE_EXPANSION =
       "+experimental_lazy_template_expansion";
-  public static final String EXPERIMENTAL_ANALYSIS_TEST_CALL = "+experimental_analysis_test_call";
   public static final String INCOMPATIBLE_ALWAYS_CHECK_DEPSET_ELEMENTS =
       "+incompatible_always_check_depset_elements";
   public static final String INCOMPATIBLE_DEPSET_FOR_LIBRARIES_TO_LINK_GETTER =

diff --git a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/test/TestingModuleApi.java b/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/test/TestingModuleApi.java
@@ -15,7 +15,6 @@
 package com.google.devtools.build.lib.starlarkbuildapi.test;
 
 import com.google.devtools.build.docgen.annot.DocCategory;
-import com.google.devtools.build.lib.packages.semantics.BuildLanguageOptions;
 import com.google.devtools.build.lib.starlarkbuildapi.RunEnvironmentInfoApi;
 import com.google.devtools.build.lib.starlarkbuildapi.StarlarkRuleFunctionsApi;
 import net.starlark.java.annot.Param;
@@ -136,8 +135,7 @@ RunEnvironmentInfoApi testEnvironment(
             defaultValue = "{}",
             doc = "Dictionary of attribute values to pass to the implementation."),
       },
-      useStarlarkThread = true,
-      enableOnlyWithFlag = BuildLanguageOptions.EXPERIMENTAL_ANALYSIS_TEST_CALL)
+      useStarlarkThread = true)
   void analysisTest(
       String name,
       StarlarkFunction implementation,