Skip to content

Commit b747a4f

Browse files
lberkicopybara-github
authored andcommitted
Remove the --experimental_analysis_test_call command line option.
RELNOTES[INC]: testing.analysis_test is not experimental anymore PiperOrigin-RevId: 568547119 Change-Id: Ib9d5c543f33cf73f6c681a2c45f2fd7e47774a85
1 parent 480c8c8 commit b747a4f

File tree

2 files changed

+1
-16
lines changed

2 files changed

+1
-16
lines changed

src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -370,17 +370,6 @@ public final class BuildLanguageOptions extends OptionsBase {
370370
+ " parameter for deferred evaluation of substitution values.")
371371
public boolean experimentalLazyTemplateExpansion;
372372

373-
@Option(
374-
name = "experimental_analysis_test_call",
375-
defaultValue = "true",
376-
documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
377-
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS, OptionEffectTag.BUILD_FILE_SEMANTICS},
378-
metadataTags = {
379-
OptionMetadataTag.EXPERIMENTAL,
380-
},
381-
help = "If set to true, analysis_test native call is available.")
382-
public boolean experimentalAnalysisTestCall;
383-
384373
@Option(
385374
name = "incompatible_struct_has_no_methods",
386375
defaultValue = "false",
@@ -759,7 +748,6 @@ public StarlarkSemantics toStarlarkSemantics() {
759748
INCOMPATIBLE_EXISTING_RULES_IMMUTABLE_VIEW, incompatibleExistingRulesImmutableView)
760749
.setBool(EXPERIMENTAL_ACTION_RESOURCE_SET, experimentalActionResourceSet)
761750
.setBool(EXPERIMENTAL_LAZY_TEMPLATE_EXPANSION, experimentalLazyTemplateExpansion)
762-
.setBool(EXPERIMENTAL_ANALYSIS_TEST_CALL, experimentalAnalysisTestCall)
763751
.setBool(EXPERIMENTAL_GOOGLE_LEGACY_API, experimentalGoogleLegacyApi)
764752
.setBool(EXPERIMENTAL_PLATFORMS_API, experimentalPlatformsApi)
765753
.setBool(EXPERIMENTAL_CC_SHARED_LIBRARY, experimentalCcSharedLibrary)
@@ -870,7 +858,6 @@ public StarlarkSemantics toStarlarkSemantics() {
870858
public static final String EXPERIMENTAL_ACTION_RESOURCE_SET = "+experimental_action_resource_set";
871859
public static final String EXPERIMENTAL_LAZY_TEMPLATE_EXPANSION =
872860
"+experimental_lazy_template_expansion";
873-
public static final String EXPERIMENTAL_ANALYSIS_TEST_CALL = "+experimental_analysis_test_call";
874861
public static final String INCOMPATIBLE_ALWAYS_CHECK_DEPSET_ELEMENTS =
875862
"+incompatible_always_check_depset_elements";
876863
public static final String INCOMPATIBLE_DEPSET_FOR_LIBRARIES_TO_LINK_GETTER =

src/main/java/com/google/devtools/build/lib/starlarkbuildapi/test/TestingModuleApi.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
package com.google.devtools.build.lib.starlarkbuildapi.test;
1616

1717
import com.google.devtools.build.docgen.annot.DocCategory;
18-
import com.google.devtools.build.lib.packages.semantics.BuildLanguageOptions;
1918
import com.google.devtools.build.lib.starlarkbuildapi.RunEnvironmentInfoApi;
2019
import com.google.devtools.build.lib.starlarkbuildapi.StarlarkRuleFunctionsApi;
2120
import net.starlark.java.annot.Param;
@@ -136,8 +135,7 @@ RunEnvironmentInfoApi testEnvironment(
136135
defaultValue = "{}",
137136
doc = "Dictionary of attribute values to pass to the implementation."),
138137
},
139-
useStarlarkThread = true,
140-
enableOnlyWithFlag = BuildLanguageOptions.EXPERIMENTAL_ANALYSIS_TEST_CALL)
138+
useStarlarkThread = true)
141139
void analysisTest(
142140
String name,
143141
StarlarkFunction implementation,

0 commit comments

Comments
 (0)