Skip to content

Commit

Permalink
Automated rollback of commit dadc49e.
Browse files Browse the repository at this point in the history
*** Reason for rollback ***

Breaks Tensorflow. See #16296

*** Original change description ***

Apply graph_structure aspect across all edges

RELNOTES: None.
PiperOrigin-RevId: 480381529
Change-Id: Ied2f6b14a4b80e3c77691cf716c199b9c8a63f85
  • Loading branch information
c-parsons authored and fweikert committed Oct 20, 2022
1 parent 8760a91 commit c6f921f
Showing 1 changed file with 5 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -586,21 +586,11 @@ def _cc_shared_library_impl(ctx):
def _graph_structure_aspect_impl(target, ctx):
children = []

# Collect graph structure info from any possible deplike attribute. The aspect
# itself applies across every deplike attribute (attr_aspects is *), so enumerate
# over all attributes and consume GraphNodeInfo if available.
for fieldname in dir(ctx.rule.attr):
if fieldname == "_cc_toolchain" or fieldname == "target_compatible_with":
continue
deps = getattr(ctx.rule.attr, fieldname, None)
if type(deps) == "list":
for dep in deps:
if type(dep) == "Target" and GraphNodeInfo in dep:
children.append(dep[GraphNodeInfo])

# Single dep.
elif type(deps) == "Target" and GraphNodeInfo in deps:
children.append(deps[GraphNodeInfo])
# For now ignore cases when deps is of type label instead of label_list.
if hasattr(ctx.rule.attr, "deps") and type(ctx.rule.attr.deps) != "Target":
for dep in ctx.rule.attr.deps:
if GraphNodeInfo in dep:
children.append(dep[GraphNodeInfo])

# TODO(bazel-team): Add flag to Bazel that can toggle the initialization of
# linkable_more_than_once.
Expand Down

0 comments on commit c6f921f

Please sign in to comment.