Make the BUILD_TIMESTAMP build info entry contain the number of secon…

…ds (instead of milliseconds) since the epoch. This fixes the build stamp data in Bazel itself and is also consistent with what we do internally at Google. Fixes #4469 . RELNOTES[INC]: BUILD_TIMESTAMP now contains seconds (and not milliseconds) since the epoch. PiperOrigin-RevId: 191418132
bazelbuild · Apr 3, 2018 · e52c841 · e52c841
1 parent d92db2d
commit e52c841
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BuildInfo.java b/src/main/java/com/google/devtools/build/lib/analysis/BuildInfo.java
@@ -35,7 +35,7 @@ public class BuildInfo {
   public static final String BUILD_HOST = "BUILD_HOST";
 
   /**
-   * Build time as milliseconds since epoch
+   * Build time as seconds since epoch
    */
   public static final String BUILD_TIMESTAMP = "BUILD_TIMESTAMP";
 

diff --git a/src/main/java/com/google/devtools/build/lib/bazel/BazelWorkspaceStatusModule.java b/src/main/java/com/google/devtools/build/lib/bazel/BazelWorkspaceStatusModule.java
@@ -210,7 +210,7 @@ public ActionResult execute(ActionExecutionContext actionExecutionContext)
         stableMap.put(BuildInfo.BUILD_EMBED_LABEL, options.embedLabel);
         stableMap.put(BuildInfo.BUILD_HOST, hostname);
         stableMap.put(BuildInfo.BUILD_USER, username);
-        volatileMap.put(BuildInfo.BUILD_TIMESTAMP, Long.toString(getCurrentTimeMillis()));
+        volatileMap.put(BuildInfo.BUILD_TIMESTAMP, Long.toString(getCurrentTimeMillis() / 1000));
 
         Map<String, String> overallMap = new TreeMap<>();
         overallMap.putAll(volatileMap);