cc_import system_provided still sets rpath

[wesleyw72]

Description of the problem / feature request:

I have a cc_import with interface_library set and system_provided set to true. I'd expect a binary depending on this would show the library as NEEDED but not to add it to the RUNPATH of the binary. I'm however seeing it being added into the RUNPATH. Is this the intended behaviour?

[cdump]

@wesleyw72 have you found a solution/workaround for this?

[cdump]

Paths for RPATH constructed in LibrariesToLinkCollector.java

I think we should add something like that:

if (input.getArtifactCategory() == ArtifactCategory.INTERFACE_LIBRARY && input.isInterfaceLibrarySystemProvided()) {
 // skip add to rpath. (isInterfaceLibrarySystemProvided not exists)
}

I've also found another possible bug - input's ArtifactCategory here is DYNAMIC_LIBRARY (not INTERFACE_LIBRARY) for cc_import(interface_library="",system_provided=true). That's why:

1. CcImport.java:

• sets resolvedSymlinkInterfaceLibrary
• LibraryToLink's resolvedSymlinkInterfaceLibrary()

2. LibraryToLink.java

• sets interfaceLibraryToLink to solibLibraryToLink() (because resolvedSymlinkInterfaceLibrary from CcImport is not NULL)

3. LinkerInputs.java:

• solibLibraryToLink() creates object with ArtifactCategory=DYNAMIC_LIBRARY

I don't know the "right" way to fix this issue and need some help from more experienced in bazel source code developers.

[sgowroji]

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

[cdump]

Hi! Problem (bug) still exists and fix/help wanted