Feature Request to have child's uses-permissions exported to top level manifest #10628
Labels
P2
We'll consider working on this in future. (Assignee optional)
stale
Issues or PRs that are stale (no activity for 30 days)
team-Android
Issues for Android team
type: feature request
Comments
ahumesky
added
P2
ted-xie
pushed a commit
to ted-xie/bazel
that referenced
this issue
Jul 6, 2022
Adding support for conditionally merging `uses-permissions`. bazelbuild#10628 bazelbuild#5411 Closes bazelbuild#13445. RELNOTES: Enable merging permissions during Android manifest merging with the --merge_android_manifest_permissions flag. PiperOrigin-RevId: 439613035
ted-xie
pushed a commit
to ted-xie/bazel
that referenced
this issue
Jul 6, 2022
Adding support for conditionally merging `uses-permissions`. bazelbuild#10628 bazelbuild#5411 Closes bazelbuild#13445. RELNOTES: Enable merging permissions during Android manifest merging with the --merge_android_manifest_permissions flag. PiperOrigin-RevId: 439613035
ted-xie
pushed a commit
to ted-xie/bazel
that referenced
this issue
Jul 6, 2022
Adding support for conditionally merging `uses-permissions`. bazelbuild#10628 bazelbuild#5411 Closes bazelbuild#13445. RELNOTES: Enable merging permissions during Android manifest merging with the --merge_android_manifest_permissions flag. PiperOrigin-RevId: 439613035
ckolli5
pushed a commit
that referenced
this issue
Jul 6, 2022
* Support uses-permission merging in manifest merger Adding support for conditionally merging `uses-permissions`. #10628 #5411 Closes #13445. RELNOTES: Enable merging permissions during Android manifest merging with the --merge_android_manifest_permissions flag. PiperOrigin-RevId: 439613035 * Make ManifestMergerAction worker compatible Calling `System#exit` kills the worker during the build. Passing the exception up to the worker should be enough for it to end up in the worker or local execution output. Closes #14427. PiperOrigin-RevId: 447808701 * Fix ManifestMergerAction test case on windows `manifest.toString().replaceFirst("^/", "")` silently fails on windows machines causing `removePermissions` to write to the original test file. This pull request creates a new temp file that `removePermissions` can write the modified manifest to. Pulling this change out of another PR so that it's easier to merge. Original PR here https://github.com/bazelbuild/bazel/pull/13445/files#r631575251 Closes #13760. PiperOrigin-RevId: 438643774 Co-authored-by: Ben Lee <ben@ben.cm>
|
Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team ( |
github-actions
bot
added
the
stale
|
This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the problem / feature request:
Related: #5411
Both Gradle and Buck have an option to merge all uses-permissions manifest enteries from child libs to the top level final binary manifest. It would be nice if Bazel supported that as well.
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Expected the permission from library to be present
Actual it's not present.
What's the output of
bazel info release?1.2.1
Any other information, logs, or outputs that you want to share?
btw, there is a current bug in bazel where it actually inherits some permissions from child aar_imports. So if you have android_binary that deps on android_library that deps on aar_import that has permissions -- those permissions will be exported.
The text was updated successfully, but these errors were encountered: