Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterTestHeaderOutputStream doesn't respect system line separator #10931

Closed
laurentlb opened this issue Mar 9, 2020 · 1 comment
Closed

FilterTestHeaderOutputStream doesn't respect system line separator #10931

laurentlb opened this issue Mar 9, 2020 · 1 comment
Labels
area-Windows Windows-specific issues and feature requests team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website untriaged

Comments

@laurentlb
Copy link
Contributor

private static final int NEWLINE = '\n';

bazel/src/main/java/com/google/devtools/build/lib/exec/TestLogHelper.java

Line 95 in 59f17d6

private static final int NEWLINE = '\n';

cc @meteorcloudy
@laurentlb laurentlb added area-Windows Windows-specific issues and feature requests untriaged labels Mar 9, 2020
@michajlo
Copy link
Contributor

michajlo commented Mar 9, 2020

See also https://github.com/bazelbuild/bazel/blob/master/src/test/java/com/google/devtools/build/lib/exec/StreamedTestOutputTest.java#L70

meteorcloudy added a commit to meteorcloudy/bazel that referenced this issue Mar 10, 2020
@meteorcloudy
Make FilterTestHeaderOutputStream respect line separator on Windows
d5c9c53 
Fixes bazelbuild#10931
@meteorcloudy meteorcloudy mentioned this issue Mar 10, 2020
Closed
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Make FilterTestHeaderOutputStream respect line separator on Windows
f17502b 
    Fixes bazelbuild/bazel#10931

    Closes #10935.

    PiperOrigin-RevId: 300112038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Windows Windows-specific issues and feature requests team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make FilterTestHeaderOutputStream respect line separator on Windows meteorcloudy/bazel
3 participants
@michajlo @laurentlb @philwo