Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependencies on gflags #11544

Closed
aiuto opened this issue Jun 4, 2020 · 5 comments
Closed

remove dependencies on gflags #11544

aiuto opened this issue Jun 4, 2020 · 5 comments
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Comments

@aiuto
Copy link
Contributor

aiuto commented Jun 4, 2020

This is almost complete, but it is still in third_party and some integration tests seem to make use of it being in the source tree - which seems strangely brittle. Giving this to @meteorcloudy on the grounds that helps with debian cleanliness.

@aiuto aiuto added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website untriaged labels Jun 4, 2020
@jin
Copy link
Member

jin commented Aug 25, 2020

Looks like gflags have been removed in 3.4 https://blog.bazel.build/2020/07/13/bazel-3-4.html#incompatible-changes

@aiuto
Copy link
Contributor Author

aiuto commented Aug 25, 2020

It is still bundled in bazel third_party, even though bazel does not use it any more.
I am not sure if the note for 3.4 is correct. People might sill be able to use it.

@jin
Copy link
Member

jin commented Aug 25, 2020

I received a user report from @stepango that the package was removed, during an upgrade to 3.4.x (so unfortunately it was a breaking change without an --incompatible flag)

@aiuto
Copy link
Contributor Author

aiuto commented Aug 25, 2020

Whoops. We miss occasionally. I wonder why it still shows up in the source tree?
But I don't wonder enough to look right now. I am happy to leave this open so we remember to remove the code from the source tree. That should also make the Debian packaging people happier.

@philwo
Copy link
Member

philwo commented Nov 25, 2020

I think gflags is 100% gone now.

@philwo philwo closed this as completed Nov 25, 2020
@philwo philwo removed the untriaged label Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

No branches or pull requests

3 participants