-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dependencies on gflags #11544
Comments
Looks like gflags have been removed in 3.4 https://blog.bazel.build/2020/07/13/bazel-3-4.html#incompatible-changes |
It is still bundled in bazel third_party, even though bazel does not use it any more. |
I received a user report from @stepango that the package was removed, during an upgrade to 3.4.x (so unfortunately it was a breaking change without an --incompatible flag) |
Whoops. We miss occasionally. I wonder why it still shows up in the source tree? |
I think gflags is 100% gone now. |
This is almost complete, but it is still in third_party and some integration tests seem to make use of it being in the source tree - which seems strangely brittle. Giving this to @meteorcloudy on the grounds that helps with debian cleanliness.
The text was updated successfully, but these errors were encountered: