Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow UrlRewriter to override protocol #13114

Closed
denyska opened this issue Feb 26, 2021 · 0 comments
Closed

Allow UrlRewriter to override protocol #13114

denyska opened this issue Feb 26, 2021 · 0 comments
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged

Comments

@denyska
Copy link
Contributor

denyska commented Feb 26, 2021

Description of the problem / feature request:

Allow UrlRewriter to re-write protocol along with hostname. i.e. https -> http, http -> https. At the moment Urlrewriter assumes the same protocol will be used.

Feature requests: what underlying problem are you trying to solve with this feature?

UrlRewriter's main use case is to point public urls to private artifact repositories. Some of the internal repos are HTTP-only. For ex., we run forwarding proxy as side car on the build agents. The proxy internally forwards and caches requests to central artifact storage that uses complex authentication. There is no security/performance benefits of running this proxy with HTTPS enabled.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

N/A

What operating system are you running Bazel on?

MacOS

What's the output of bazel info release?

bazel info release

If bazel info release returns "development version" or "(@non-git)", tell us how you built Bazel.

N/A

What's the output of git remote get-url origin ; git rev-parse master ; git rev-parse HEAD ?

N/A

Have you found anything relevant by searching the web?

Nope

Any other information, logs, or outputs that you want to share?

N/A

@jin jin added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website untriaged labels Mar 1, 2021
philwo pushed a commit that referenced this issue Mar 15, 2021
philwo pushed a commit that referenced this issue Mar 15, 2021
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants