Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for #13110 #13167

Closed
wants to merge 2 commits into from
Closed

Documentation for #13110 #13167

wants to merge 2 commits into from

Conversation

quval
Copy link
Contributor

@quval quval commented Mar 6, 2021

Copy link
Member

@katre katre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left one comment, but in general can you please clarify that this is coming from execution platforms, not target platforms?

It is possible to define `exec_properties` for arbitrary execution groups on
platform targets (unlike `exec_properties` set directly on a target, where
properties for unknown execution groups are rejected). Targets then inherit the
platform's `exec_properties` that affect the default execution group and any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Targets then inherit the execution platform's exec_proeprties"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (here and in one other place) - not sure if it should be made clearer.

Copy link
Member

@katre katre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this today.

@quval
Copy link
Contributor Author

quval commented Mar 8, 2021

Thank you!

@bazel-io bazel-io closed this in 8186fbb Mar 9, 2021
philwo pushed a commit that referenced this pull request Mar 15, 2021
Closes #13167.

PiperOrigin-RevId: 361885312
philwo pushed a commit that referenced this pull request Mar 15, 2021
Closes #13167.

PiperOrigin-RevId: 361885312
katre pushed a commit that referenced this pull request Jul 12, 2021
Closes #13167.

PiperOrigin-RevId: 361885312
katre pushed a commit to katre/bazel that referenced this pull request Jul 13, 2021
Closes bazelbuild#13167.

PiperOrigin-RevId: 361885312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants