Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.2 - June 2021 #13558

Closed
9 tasks done
philwo opened this issue Jun 7, 2021 · 124 comments
Closed
9 tasks done

Release 4.2 - June 2021 #13558

philwo opened this issue Jun 7, 2021 · 124 comments
Assignees
@katre
Labels
P1 I'll work on this now. (Assignee required) release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process

Comments

@philwo
Copy link
Member

philwo commented Jun 7, 2021 •
edited by katre
Loading

Status of Bazel 4.2

This release will use Bazel 4.1.0 as its baseline and we will apply selected cherry-picks and backports on top of it. Please request cherry-picks that you'd like to get into Bazel 4.2.0 here via a comment.

To report a release-blocking bug, please file a bug using the Release blocker label, and cc me.

Task list:
@philwo philwo added P1 I'll work on this now. (Assignee required) type: process release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Jun 7, 2021
@philwo philwo pinned this issue Jun 7, 2021
@philwo
Copy link
Member Author

philwo commented Jun 7, 2021

Requested cherry picks

Unreviewed:

Accepted:

  • ...

Rejected:

  • ...

@quval
Copy link
Contributor

quval commented Jun 7, 2021

Would it be possible to cherry-pick 1e258d2, d067669, f1e0d34 and 8186fbb again into 4.2.0, as well as the commits fixing #13459?

@philwo philwo mentioned this issue Jun 7, 2021
Closed
@thii
Copy link
Member

thii commented Jun 7, 2021

Can I request these two? Some rulesets like rules_swift are pretty aggressive on using these new features.

  • 50ce3f9: starlark: allow lambda expressions
  • 5ca2064: starlark: allow nested def statements

@ahumesky
Copy link
Contributor

ahumesky commented Jun 7, 2021

Could we please have 80feea0 for the android rules, thanks!

@ahumesky
Copy link
Contributor

ahumesky commented Jun 7, 2021

And also a followup 0e65273 for the android rules

@cpsauer
Copy link
Contributor

cpsauer commented Jun 7, 2021

Any chance we could cherrypick 1a0285c?

@gregestren
Copy link
Contributor

gregestren commented Jun 8, 2021 •
edited
Loading

Request:

@brentleyjones
Copy link
Contributor

Can we also include 7643d3a?

@brentleyjones
Copy link
Contributor

Also this one: 95c7931

@mai93
Copy link
Contributor

mai93 commented Jun 10, 2021

Can you please include 1bca1bd?

@brentleyjones
Copy link
Contributor

Can we please include f0983df?

@martis42
Copy link

Please include cac82cf

@csmulhern
Copy link
Contributor

Can we include b06f495?

@csmulhern csmulhern mentioned this issue Jun 13, 2021
Merged
@FaBrand
Copy link
Contributor

FaBrand commented Jun 16, 2021

Can this bugfix be included 382fd64 ?

@meteorcloudy
Copy link
Member

We'll need b4b0c32 to fix #13514

@jablin
Copy link
Contributor

jablin commented Jun 18, 2021

Please include 5d7df56 .

@philsc
Copy link
Contributor

philsc commented Jun 21, 2021 •
edited
Loading

Can we get 9868455 and d052ece cherry-picked?
The former is required for the latter to apply cleanly.

EDIT: It appears that 9868455 isn't actually necessary for a cherry-pick of d052ece. I was convinced that it was, apologies.

@simonfall simonfall mentioned this issue Jun 22, 2021
Closed
6 tasks
@jesec
Copy link
Contributor

jesec commented Jun 26, 2021 •
edited
Loading

Please consider:

Thanks.

@coeuvre
Copy link
Member

coeuvre commented Jun 28, 2021 •
edited
Loading

Please include following commits for remote execution (in committed order):

  • ae53991 Remote: Add RemoteExecutionService as a layer between spawn execution and remote execution.
  • cd477f2 Pass only the top-level artifacts to ExecutorLifecycleListener and make the computation more efficient.
  • 1e803ab Remove default build options.
  • 275c54c Change the signature of tree artifact expansion to allow passing a reference to children from TreeArtifactValue to ArtifactExpanderImpl.
  • 300c11e Separate Fileset-symlink errors out from I/O exceptions, and propagate them everywhere.
  • fd9cffd Suppress interrupted status during pool closure
  • 0c07c2e Remote: Add remoteCacheable key to execution log
  • 95c7931 Remote: Add remoteCacheHits to BEP BuildMetrics.
  • 7643d3a Remote: Register "remote" strategy even if remote execution is not available.
  • 4ca8946 Remote: Add --experimental_capture_corrupted_outputs flag.
  • f0983df Remote: Report checking cache status before the action is scheduled to run remotely.
  • 4261b2a Inclusive naming fixit
  • ba5b2a7 when writing to local disk cache, open files later in order to avoid "too many open files"
  • 97fb2cf Remote: Fix a bug that the XML generation is executed even if test.xml is generated when build with --remote_download_minimal.
  • 2ace97f Move ActionInputHelper to a separate target.
  • af42653 Automatic code cleanup.
  • 07a84ce Remote: Another attempt to fix the CancellationException error in AsyncTaskCache caused by a race condition.
  • 0f812eb Remote: Display download progress when actions are downloading outputs from remote cache.
  • Remote: Do not upload empty output to remote cache. #13594

@katre katre self-assigned this Jul 8, 2021
@katre
Copy link
Member

katre commented Jul 8, 2021

I plan to start assembling the branch for this release on Monday, July 12, so expect further updates around then.

It's a long list of cherrypicks so it may take some time to determine which can be applied and which cannot.

@jayconrod
Copy link
Contributor

Could we please include c9f9eed? It will unblock some work on Go static analysis.

@katre
Copy link
Member

katre commented Aug 26, 2021

Downsteam tests for RC2 look clean: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2155

Barring further regressions I'll release 4.2.1 Monday morning.

@katre katre mentioned this issue Aug 30, 2021
Closed
@katre
Copy link
Member

katre commented Aug 30, 2021

Bazel 4.2.1 is now live: https://github.com/bazelbuild/bazel/releases/tag/4.2.1

Please update your packages if possible: @vbatts @petemounce @excitoon

katre added a commit to katre/bazel that referenced this issue Aug 30, 2021
@katre
Update documentation for Bazel 4.2.1 (bazelbuild#13558).
419c3fb
bazel-io pushed a commit that referenced this issue Aug 30, 2021
@katre
Update documentation for Bazel 4.2.1 (#13558).
e70d9e9 
Closes #13922.

PiperOrigin-RevId: 393788736
@anthpi
Copy link

anthpi commented Sep 3, 2021

When building 4.2.0 and 4.2.1 I get "tools/jdk/BUILD:41:15: //tools/jdk:dummy_toolchain: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule" error. Any idea what could cause it?

@katre
Copy link
Member

katre commented Sep 3, 2021

@anthpi Please file a separate issue with reproduction instructions and we'll investigate.

@katre katre closed this as completed Sep 7, 2021
@alexeagle alexeagle mentioned this issue Sep 13, 2021
Merged
@thii thii mentioned this issue Oct 8, 2021
Closed
@omarzl
Copy link
Contributor

omarzl commented Oct 8, 2021

Hello there! These are my first contributions to the repo, I sent a cherry pick pr #14086 to 4.2.1 but it is already released, can a 4.2.2 or 4.3.0 be opened? Or should I send it to 5.0? Thanks!

@philwo
Copy link
Member Author

philwo commented Oct 11, 2021

@omarzl Your change will definitely be included as part of Bazel 5.0, there's no action required on your side for this.

It looks pretty low risk, so if we decide to make a Bazel 4.3 release, we can consider it for cherry picking there. If I misunderstood this change and that's actually a fix for a regression or new bug in Bazel 4.2, please let me know - then we should consider creating a patch release (4.2.2).

@omarzl
Copy link
Contributor

omarzl commented Oct 11, 2021

Hi @philwo, perfectly fine in 5.0 or 4.3 (if exists), thank you!

@katre katre unpinned this issue Oct 18, 2021
@limdor
Copy link
Contributor

limdor commented Oct 27, 2021

In case anyone here has an idea, we have detected a possible regression between Bazel 4.0.0 and Bazel 4.2.1 regarding the command line parameter --remote_max_connections that seems to be ignored. Unfortunately it is still quite fresh and we do not have a reproducible example. We will create a ticket as soon as we have some more information.

@limdor
Copy link
Contributor

limdor commented Oct 27, 2021

And here the ticket #14178

@katre
Copy link
Member

katre commented Oct 27, 2021

Bazel 5.0 has just been cut, so we won't be releasing any more versions in the 4.2 series. We can definitely look into getting #14178 addressed for 5.0, however.

@limdor
Copy link
Contributor

limdor commented Oct 28, 2021

we won't be releasing any more versions in the 4.2 series

Can you clarify that please? Should we expect to not have anymore a Bazel 4.X release or only for the 4.2 series and would be a 4.3 series? Not releasing anymore a Bazel 4.X release would contradict with what was announced when introducing LTS
https://blog.bazel.build/2020/11/10/long-term-support-release.html

@katre
Copy link
Member

katre commented Oct 28, 2021

You're right, I misunderstood the situation. We won't be preparing any further releases in the 4.x series on a regular schedule, but any serious regressions or other bugs we may prepare a further release in the 4.x series.

If there is a fix for #14178 and it applies clearly on top of 4.2 we can look at a 4.3 release. We will not be considering feature cherrypicks for 4.3, however.

@limdor
Copy link
Contributor

limdor commented Oct 28, 2021

You're right, I misunderstood the situation. We won't be preparing any further releases in the 4.x series on a regular schedule, but any serious regressions or other bugs we may prepare a further release in the 4.x series.

Thanks for the clarification.

@limdor
Copy link
Contributor

limdor commented Nov 16, 2021

@katre there is a fix for #14178 that went in with 063b5c9
I just tried to cherry pick this commit on top of the 4.2.1 tag and it is applied cleaned.
Could you and the Bazel team consider a 4.3 release and answer here about the decision?
Thanks

@meteorcloudy
Copy link
Member

meteorcloudy commented Nov 24, 2021 •
edited
Loading

We are doing a 4.2.2 patch release for #14178 and probably #14273.
Please send PRs for the fixes to https://github.com/bazelbuild/bazel/tree/release-4.2.2-patches

@limdor
Copy link
Contributor

limdor commented Nov 24, 2021 •
edited
Loading

We are doing a 4.2.2 patch release for #14178 and probably #14273. Please send PRs for the fixes to https://github.com/bazelbuild/bazel/tree/release-4.2.2-patches

Great!, I created a PR for #14178, if I should add some special tag just let me know #14318 currently tests are running

@bjacklyn
Copy link

Please consider #13985 as well -- fixes bazel UI bug introduced in 4.2.0

@meteorcloudy
Copy link
Member

@bjacklyn Can you also send a PR to the release-4.2.2-patches branch?

@meteorcloudy
Copy link
Member

Bazel 4.2.2rc1 is now available: https://releases.bazel.build/4.2.2/rc1/index.html

Cherry-picks since 4.2.1:

Downstream tests haven't show any breakage from the Bazel side: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2262

@meteorcloudy meteorcloudy reopened this Nov 25, 2021
@meteorcloudy
Copy link
Member

Bazel 4.2.2 is now live: https://github.com/bazelbuild/bazel/releases/tag/4.2.2

Please update your packages if possible: @vbatts @petemounce @excitoon

@petemounce
Copy link
Contributor

Published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
P1 I'll work on this now. (Assignee required) release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests