Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jack compilation for Bazel #1391

Closed
programmablereya opened this issue Jun 13, 2016 · 2 comments
Closed

Support Jack compilation for Bazel #1391

programmablereya opened this issue Jun 13, 2016 · 2 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request

Comments

@programmablereya
Copy link

Although Jack is technically supported, it's not part of the android_sdk_repository rule yet. And it can't be for a little while; in order to support Bazel's current integration with Jack, the version of Jack must support both the new workflow for Jack (supported in Brest, present in 23.0.1+) and the --tolerant flag (not yet released AFAIK). Since the latter is not supported yet, this feature should be on hold for a little while; this issue just tracks this actually getting done.

As for the work that actually needs to be done - there are some wrapper scripts internally designed to smooth over any difficulties in calling Jack. These need to be released and integrated with the android_sdk_repository rule based on the build tools version being appropriate.

@hermione521 hermione521 added type: feature request P3 We're not considering working on this, but happy to review a PR. (No assignee) category: mobile labels Jun 14, 2016
@hermione521
Copy link
Contributor

Added labels, feel free to change.

@iamironz
Copy link

Jack is now deprecated (https://android-developers.googleblog.com/2017/03/future-of-java-8-language-feature.html). Feature request are not actual.

bazel-io pushed a commit that referenced this issue Apr 5, 2017
#1391

RELNOTES: None

PiperOrigin-RevId: 152179305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants