Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CC rules to use optional toolchains #14727

Closed
katre opened this issue Feb 4, 2022 · 0 comments
Closed

Update CC rules to use optional toolchains #14727

katre opened this issue Feb 4, 2022 · 0 comments
Assignees
@katre
Labels
team-Rules-CPP Issues for C++ rules type: feature request

Comments

@katre
Copy link
Member

katre commented Feb 4, 2022

Once #14726 is done, the CC rules need to use optional toolchains, then we can remove the dummy cc toolchain.
@katre katre self-assigned this Feb 4, 2022
katre added a commit to katre/bazel that referenced this issue Feb 7, 2022
@katre
Add a helper method for rules to depend on the cpp toolchain type.
ec642b6 
Fixes bazelbuild#14728, part of bazelbuild#14727.

Rules can begin using this as soon as it is released (hopefully in Bazel
5.1), and then future versions of Bazel will update the functionality as
optional toolchains are added and C++ rules are updated to use them.
@katre katre mentioned this issue Feb 7, 2022
Closed
bazel-io pushed a commit that referenced this issue Feb 11, 2022
@katre
Add a helper method for rules to depend on the cpp toolchain type.
86e2db7 
Fixes #14728, part of #14727.

Rules can begin using this as soon as it is released (hopefully in Bazel
5.1), and then future versions of Bazel will update the functionality as
optional toolchains are added and C++ rules are updated to use them.

Closes #14742.

PiperOrigin-RevId: 427931123
fmeum pushed a commit to fmeum/bazel that referenced this issue Feb 11, 2022
@katre @fmeum
Add a helper method for rules to depend on the cpp toolchain type.
50ce800 
Fixes bazelbuild#14728, part of bazelbuild#14727.

Rules can begin using this as soon as it is released (hopefully in Bazel
5.1), and then future versions of Bazel will update the functionality as
optional toolchains are added and C++ rules are updated to use them.

Closes bazelbuild#14742.

PiperOrigin-RevId: 427931123
@fmeum fmeum mentioned this issue Feb 11, 2022
Merged
Wyverald pushed a commit that referenced this issue Feb 14, 2022
@fmeum @katre
Add a helper method for rules to depend on the cpp toolchain type. (#…
af34c45 
…14795)

Fixes #14728, part of #14727.

Rules can begin using this as soon as it is released (hopefully in Bazel
5.1), and then future versions of Bazel will update the functionality as
optional toolchains are added and C++ rules are updated to use them.

Closes #14742.

PiperOrigin-RevId: 427931123

Co-authored-by: John Cater <jcater@google.com>
@katre katre mentioned this issue May 4, 2022
Closed
bazel-io pushed a commit that referenced this issue May 17, 2022
@katre
Add helper to centrally define the CC toolchain type requirement.
c1009c2 
Everything that gets a CC toolchain via CppHelper.getToolchain should use this helper.

Part of #14727.

PiperOrigin-RevId: 449233884
bazel-io pushed a commit that referenced this issue May 17, 2022
@katre
Add a helper for declaring the cc toolchain type on rules in builtins.
fc5bf54 
Part of #14727.

PiperOrigin-RevId: 449242251
bazel-io pushed a commit that referenced this issue May 18, 2022
@katre
Update native rules to use a common definition for the CC toolchain t…
a54a1a7 
…ype requirement.

Part of #14727.

PiperOrigin-RevId: 449453965
copybara-service bot pushed a commit to bazelbuild/rules_cc that referenced this issue May 18, 2022
@katre
Add a use_cc_toolchain helper to rules_cc.
8bb0eb5 
Part of github.com/bazelbuild/bazel/issues/14727.

PiperOrigin-RevId: 449499388
Change-Id: I9fb5fecd1059b0d48a26e89d1c25d54fd2348b55
bazel-io pushed a commit that referenced this issue May 19, 2022
@katre
Use the helper for declaring the cc toolchain type on rules in builtins.
798bd5e 
Part of #14727.

PiperOrigin-RevId: 449703810
@katre katre mentioned this issue Jun 21, 2022
Merged
phst pushed a commit to phst/rules_elisp that referenced this issue Jun 23, 2022
@katre @phst
Use a helper to to define the cpp toolchain type
fa8690e 
Part of bazelbuild/bazel#14727
This was referenced Jun 30, 2022
Merged
Merged
mihaibudiu pushed a commit to p4lang/p4c that referenced this issue Jun 30, 2022
@katre
Use a helper to to define the cpp toolchain type (#3416)
dbd8472 
Part of bazelbuild/bazel#14727

Missed this in 2645f65
rst0git pushed a commit to rst0git/p4c that referenced this issue Jul 1, 2022
@katre @rst0git
Use a helper to to define the cpp toolchain type (p4lang#3416)
03a287c 
Part of bazelbuild/bazel#14727

Missed this in 2645f65
phst pushed a commit to phst/rules_elisp that referenced this issue Jul 2, 2022
@katre @phst
Use a helper to to define the cpp toolchain type
fb051e4 
Part of bazelbuild/bazel#14727
copybara-service bot pushed a commit that referenced this issue Jul 8, 2022
@katre
Update native CC rules to use an optional CC toolchain.
14dffd4 
If the toolchain is needed and can't be found, CppHelper will fail with a more useful error message.

Part of #14727.

PiperOrigin-RevId: 459785208
Change-Id: If191c0a5dc7cf5a1759fa0af63bd53096e9deda8
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@katre
Update CC rule helpers to use an optional CC toolchain.
a2ba0ac 
If the toolchain is needed and can't be found, _find_cpp_toolchain will fail with a more useful error message.

Part of #14727.

PiperOrigin-RevId: 460404686
Change-Id: Idb3eeffb4a96ff0158616e7a3d0201f5603cd050
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@katre
Update CC rule helpers to use an optional CC toolchain.
95f0135 
If the toolchain is needed and can't be found, find_cpp_toolchain will fail with a more useful error message.

Part of #14727.

PiperOrigin-RevId: 460405864
Change-Id: I0e9a0861037238b1283528c5d05b3f79fda28f5e
aranguyen pushed a commit to aranguyen/bazel that referenced this issue Jul 20, 2022
@katre @aranguyen
Update native CC rules to use an optional CC toolchain.
b6a21ed 
If the toolchain is needed and can't be found, CppHelper will fail with a more useful error message.

Part of bazelbuild#14727.

PiperOrigin-RevId: 459785208
Change-Id: If191c0a5dc7cf5a1759fa0af63bd53096e9deda8
aranguyen pushed a commit to aranguyen/bazel that referenced this issue Jul 20, 2022
@katre @aranguyen
Update CC rule helpers to use an optional CC toolchain.
f858612 
If the toolchain is needed and can't be found, _find_cpp_toolchain will fail with a more useful error message.

Part of bazelbuild#14727.

PiperOrigin-RevId: 460404686
Change-Id: Idb3eeffb4a96ff0158616e7a3d0201f5603cd050
aranguyen pushed a commit to aranguyen/bazel that referenced this issue Jul 20, 2022
@katre @aranguyen
Update CC rule helpers to use an optional CC toolchain.
a0548f0 
If the toolchain is needed and can't be found, find_cpp_toolchain will fail with a more useful error message.

Part of bazelbuild#14727.

PiperOrigin-RevId: 460405864
Change-Id: I0e9a0861037238b1283528c5d05b3f79fda28f5e
aranguyen pushed a commit to aranguyen/bazel that referenced this issue Jul 20, 2022
@katre @aranguyen
Update native CC rules to use an optional CC toolchain.
6357eda 
If the toolchain is needed and can't be found, CppHelper will fail with a more useful error message.

Part of bazelbuild#14727.

PiperOrigin-RevId: 459785208
Change-Id: If191c0a5dc7cf5a1759fa0af63bd53096e9deda8
aranguyen pushed a commit to aranguyen/bazel that referenced this issue Jul 20, 2022
@katre @aranguyen
Update CC rule helpers to use an optional CC toolchain.
fa5f8cc 
If the toolchain is needed and can't be found, _find_cpp_toolchain will fail with a more useful error message.

Part of bazelbuild#14727.

PiperOrigin-RevId: 460404686
Change-Id: Idb3eeffb4a96ff0158616e7a3d0201f5603cd050
aranguyen pushed a commit to aranguyen/bazel that referenced this issue Jul 20, 2022
@katre @aranguyen
Update CC rule helpers to use an optional CC toolchain.
d8d1c44 
If the toolchain is needed and can't be found, find_cpp_toolchain will fail with a more useful error message.

Part of bazelbuild#14727.

PiperOrigin-RevId: 460405864
Change-Id: I0e9a0861037238b1283528c5d05b3f79fda28f5e
@katre katre closed this as completed Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
team-Rules-CPP Issues for C++ rules type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katre