Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osx_cc_wrapper.sh wrongly treats the Mac magic tokens (i.e. @executable_path, @loader_path, @rpath) as parameter files #15069

Closed
saltylin opened this issue Mar 18, 2022 · 3 comments
Labels
team-Rules-CPP Issues for C++ rules

Comments

@saltylin
Copy link

Description of the problem / feature request:

osx_cc_wrapper.sh treats every parameter in form of @* as a parameter file. However, some external libraries (like zstd)
built with rules_foreign_cc may include the Mac magic tokens (i.e. @executable_path, @loader_path, @rpath) as trivial
parameters.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Build zstd-1.5.2 with rules_foreign_cc-0.7.1 cmake

What operating system are you running Bazel on?

Mac OS X

What's the output of bazel info release?

release 5.0.0

What's the output of git remote get-url origin ; git rev-parse master ; git rev-parse HEAD ?

https://github.com/bazelbuild/bazel.git
6613f6f
6613f6f

Have you found anything relevant by searching the web?

No

@keith
Copy link
Member

keith commented Mar 18, 2022

Fixed by #13148

@sgowroji sgowroji added team-Rules-CPP Issues for C++ rules untriaged and removed untriaged labels Mar 19, 2022
@sgowroji
Copy link
Member

Hello @saltylin, Could you please verify the Fix mentioned in the above comment after it is reflected in the release.

@keith
Copy link
Member

keith commented Apr 19, 2022

This can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants