-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatDx producting excessive "stack map table" warnings #15751
Comments
This was originally reported here but has been broken out into a new issue specifically reporting the warnings. |
From some quick internet sleuthing, it looks like these warning can be produced when the ClassWriter instance doesn't have ClassWriter.COMPUTE_FRAMES set. I see a bunch of references to ClassWriter and associated flags (COMPUTE_FRAMES, COMPUTE_MAXS) in the desugarer code but none for the dexer somehow. Needs more investigation. @Bencodes did you see this warning pop up with the legacy dexer? |
@ted-xie not that i'm aware of but we haven't used the |
If it helps, I did a bisect to figure out which version of R8/D8 this issue was introduced in and found that the switch from version 2.1.96 (builds with with no warnings) to 2.2.64 (console gets spammed with warnings) is where it started happening. Note: I was only looking at major and not minor releases so skipped over 2.2.60. |
Thanks, Ben. I tried to git-diff those two tags in the r8 repo and there was way too much to look at; I'll try to come up with some bisect automation to make this easier. |
Just to refine this search a bit more in case it helps, it seems like the stack map issues were introduced in 2.2.60. |
Thanks, Ben. I'm marking this P2 for now; I'll try to jump back on this after a few more things clear off my plate. |
@ted-xie to quickly circle back here - this doesn't seem to be an issue using R8 instead of Proguard. |
Description of the bug:
After updating to rolling release 6.0.0-pre.20220526.1, CompatDx produces a massive amount of "stack map table" warnings.
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Which operating system are you running Bazel on?
Mac OS
What is the output of
bazel info release
?6.0.0-pre.20220526.1
If
bazel info release
returnsdevelopment version
or(@non-git)
, tell us how you built Bazel.No response
What's the output of
git remote get-url origin; git rev-parse master; git rev-parse HEAD
?No response
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
No response
The text was updated successfully, but these errors were encountered: