Crash on using TEST_NAME as an environment variable name in rules

[varungandhi-src]

Description of the bug:

Passing an environment variable with the name TEST_NAME causes Bazel to crash. Renaming it to (say) MY_TEST_NAME fixes the issue.

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Repo with minimal example: https://github.com/varungandhi-src/bazel-crash/tree/042d1747b4e76c3e9e089cd72222bd3b5a36fdf5

Test with bazel test //....

The main problematic part seems to be this is this in x.bzl:

    native.sh_test(
      name = name,
      srcs = ["hello.sh"],
      deps = [],
      env = {
        "TEST_NAME": "ohno", # Using TEST_NAME creates a collision
      },
    )

Which operating system are you running Bazel on?

macOS 12.5

What is the output of bazel info release?

release 5.2.0-homebrew

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

❯ git remote get-url origin; git rev-parse main; git rev-parse HEAD
https://github.com/varungandhi-src/bazel-crash.git
042d1747b4e76c3e9e089cd72222bd3b5a36fdf5
042d1747b4e76c3e9e089cd72222bd3b5a36fdf5

Have you found anything relevant by searching the web?

There is a similar error in #14681

Caused by: java.lang.IllegalArgumentException: Multiple entries with same key: @bazel_tools//tools/cpp:empty=[] and @bazel_tools//tools/cpp:empty=[]

But the cause seems to be different.

Any other information, logs, or outputs that you want to share?

No response

[illicitonion]

Currently bazel hard-codes setting the TEST_NAME env var itself. It's unclear whether whether this should be overridable - on the one hand, TEST_NAME isn't specified at https://bazel.build/reference/test-encyclopedia so it feels like it should be overrideable. On the other hand, other tooling may be surprised by this override.

At the very least, though, we shouldn't crash. Either we should allow overriding (and have it work), or forbid it (with documentation and a clear error message).

[varungandhi-src]

Not crashing and emitting a useful error message would be a reasonable solution IMO. 👍🏽

[github-actions]

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

[github-actions]

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please post @bazelbuild/triage in a comment here and we'll take a look. Thanks!