Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: our custom protoc-3.0.0-mingw.exe doesn't work #1856

Closed
laszlocsomor opened this issue Sep 29, 2016 · 3 comments
Closed

Windows: our custom protoc-3.0.0-mingw.exe doesn't work #1856

laszlocsomor opened this issue Sep 29, 2016 · 3 comments
Assignees
Labels
P1 I'll work on this now. (Assignee required) platform: windows type: bug

Comments

@laszlocsomor
Copy link
Contributor

$ export ARGS="-Isrc/main/protobuf -Isrc/main/java/com/google/devtools/build/lib/buildeventstream/proto --java_out=/c/tempdir/longpath/android_deploy_info.jar --plugin=protoc-gen-grpc=third_party/grpc/protoc-gen-grpc-java-0.15.0-windows-x86_64.exe --grpc_out=/c/tempdir/longpath/ src/main/protobuf/android_deploy_info.proto"

$ third_party/protobuf/protoc-mingw.exe $ARGS ; echo $?
0

$ third_party/protobuf/3.0.0/protoc-3.0.0-mingw.exe $ARGS ; echo $?
127

$ third_party/protobuf/3.0.0/protoc-3.0.0-windows-x86_64.exe $ARGS ; echo $?
0
@laszlocsomor
Copy link
Contributor Author

This bug was caused by #1851

@laszlocsomor laszlocsomor self-assigned this Sep 29, 2016
@laszlocsomor
Copy link
Contributor Author

The custom-built 3.0.0 mingw binary is just 28K, it's missing all its dependencies.
I built a statically-linked binary which works and is 55M, which is a lot more realistic as it's closer to the combined size of the DLLs. Building a dynamically-linked binary now to check its size.

bazel-io pushed a commit that referenced this issue Sep 29, 2016
See #1856

Slightly reformat (prettify) the page too.

--
MOS_MIGRATED_REVID=134649252
@ahumesky
Copy link
Contributor

Thanks!

bazel-io pushed a commit that referenced this issue Sep 30, 2016
*** Reason for rollback ***

Windows protoc compiler fixed: #1856

*** Original change description ***

Automated [] rollback of commit a12aae7.

*** Reason for rollback ***

Breaks Bazel Windows Bootstrap 
Fix #1851

*** Original change description ***

Updates protobuf in bazel to version 3.0.0.

--
MOS_MIGRATED_REVID=134699683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) platform: windows type: bug
Projects
None yet
Development

No branches or pull requests

2 participants