Remove unused Apple simulator starlark API #19169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
As far as I can tell these starlark APIs have never been used by rules_apple, and I can't find any other uses of them on GitHub. The intent of these was to replace the iOS specific API which is used in rules_apple but at this point if these are ever needed by the rules we should use a custom starlark flag instead of a bazel flag.
keith
force-pushed
the
ks/remove-unused-apple-simulator-starlark-api
branch
from
2a029f4
to
4149cf6
Compare
|
maybe google uses these internally? (not on the upstream branch of rules_apple but somewhere else) |
|
These do indeed look to be dead code. I'll have a closer look by patching Bazel derivatives to see if anything at all changes with these removed. If nothing at all changes, I'm happy to sign off on this one. |
|
It appears that there's no visible changes in the interactions with internal bits. This particular change seems safe to me. Will likely sign off after the buildkite checks complete, as long as they look good. |
nglevin
approved these changes
Aug 9, 2023
nglevin
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell these starlark APIs have never been used by rules_apple, and I can't find any other uses of them on GitHub. The intent of these was to replace the iOS specific API which is used in rules_apple but at this point if these are ever needed by the rules we should use a custom starlark flag instead of a bazel flag.