Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel_compatibility should support pre-releases #19189

Open
hvadehra opened this issue Aug 7, 2023 · 3 comments
Open

bazel_compatibility should support pre-releases #19189

hvadehra opened this issue Aug 7, 2023 · 3 comments
Assignees
@meteorcloudy
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request

Comments

@hvadehra
Copy link
Member

hvadehra commented Aug 7, 2023

Description of the feature request:

module.bazel_compatibility currently only supports release versions

Which category does this issue belong to?

External Dependency

What underlying problem are you trying to solve with this feature?

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response
@meteorcloudy meteorcloudy added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. area-Bzlmod Bzlmod-specific PRs, issues, and feature requests labels Aug 7, 2023
@meteorcloudy
Copy link
Member

/cc @SalmaSamy

@meteorcloudy
Copy link
Member

Probably need to upgrade to https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileGlobals.java;l=65?q=%22bazel_compatibility%22&ss=bazel

@fmeum
Copy link
Collaborator

fmeum commented Aug 7, 2023

@hvadehra In the meantime you can just revert the rules_java commit that added this compatibility requirement. It will be outdated anyway as this change would be in a new prerelease.

copybara-service bot pushed a commit to bazelbuild/rules_java that referenced this issue Aug 7, 2023
@hvadehra
Automated rollback of commit ca72739.
32a3927 
*** Reason for rollback ***

`bazel_compatibility` does not support pre-release versions

We can re-introduce this once bazelbuild/bazel#19189 is fixed

*** Original change description ***

Copybara Merge: #123

BEGIN_PUBLIC
Copybara import of the project:

--
3de49c8 by Fabian Meumertzheim <fabian@meumertzhe.im>:

Mark rules_java as compatible with Bazel >= 7.0.0-pre.20230710.5

Since #114, rules_java requires a version of Bazel that contains
bazelbuild/bazel@8715e9a

END_PUBLIC

***

PiperOrigin-RevId: 554463780
Change-Id: Ifdbaeb60bce59fdad3bfde8b343ed870d792eba7
@meteorcloudy meteorcloudy added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meteorcloudy meteorcloudy

Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request
Projects
Bzlmod
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hvadehra @meteorcloudy @fmeum