Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support internal jars in android support libs #1935

Closed
zvh opened this issue Oct 12, 2016 · 3 comments
Closed

Support internal jars in android support libs #1935

zvh opened this issue Oct 12, 2016 · 3 comments
Assignees
@aj-michael
Labels
P2 We'll consider working on this in future. (Assignee optional) type: bug

Comments

@zvh
Copy link

zvh commented Oct 12, 2016

The generated rules don't currently pull in the internal jars from the AAR libs/ directory which can cause compilation to fail due to missing classes. More context here:

#1745 (comment)
@zvh
Copy link
Author

zvh commented Oct 12, 2016

Please assign to @aj-michael

@aj-michael aj-michael self-assigned this Oct 12, 2016
@aj-michael
Copy link
Contributor

Thanks for filing this!

@hermione521 hermione521 added type: bug P2 We'll consider working on this in future. (Assignee optional) category: rules > android labels Oct 13, 2016
bazel-io pushed a commit that referenced this issue Oct 26, 2016
@aj-michael @katre
Merge all jars in AAR in aar_import, not just classes.jar
97cc5be 
See #1935

--
MOS_MIGRATED_REVID=137202533
@aj-michael
Copy link
Contributor

This was fixed in 97cc5be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aj-michael aj-michael

Labels
P2 We'll consider working on this in future. (Assignee optional) type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hermione521 @aj-michael @zvh