-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projects broken by testonly enforcement on ci.bazel.io: re2, rules_scala, rules_web, TensorFlow, TensorFlow_Serving #1967
Comments
testonly was not enforced in previous version of Bazel but this will be fixed in the next version of Bazel. Correct it for rules_scala. Tested with `bazel build ...` Tracking bug: bazelbuild/bazel#1967
bazelbuild/rules_scala#98 for rules_scala |
Fixing the testonly actually requires to be able to set testonly on bind or to remove all bind (I would recommend the latest). Next version of Bazel will be fixed to correctly enforce testonly so I recommend merging that change for now, then fix the external bindings. Tested with `bazel build ...` Tracking bug: bazelbuild/bazel#1967
This target is shiped into the pip_package so it is not testonly. Current version of Bazel does not enforce testonly but the next version will. Tested by building build_pip_package. Tracking bug: bazelbuild/bazel#1967
bazelbuild/rules_webtesting#20 for rules_web TensorFlow serving needs tensorflow pr in. |
(fwiw it is not really blocking the release itself, we need to fix the project). rules_webtesting have been fixed by upstream. |
testonly was not enforced in previous version of Bazel but this will be fixed in the next version of Bazel. Correct it for re2. Tested with `bazel build ...` Tracking bug: bazelbuild/bazel#1967 Change-Id: I880326e99bc8ed4904473dcf0939bd7ab3b41b26 Reviewed-on: https://code-review.googlesource.com/8610 Reviewed-by: John Cater <jcater@google.com> Reviewed-by: Paul Wankadia <junyer@google.com>
I'm using bazel 0.3.2 to compile some scala (with rules_scala at https://github.com/petemounce/rules_scala/commit/deff6c2806df8fbfc98330c06c1444140664daa2 (which is our fork with a I-think-unrelated diff), and I think I'm affected by this issue. I have a target like scala_library(
name = "testing_scala",
testonly = 1,
srcs = glob(["*.java"]),
visibility = ["//visibility:private"],
deps = [
"//third_party/scalatest",
],
) If I've understood the issue correctly, this is because of the Error output:
|
I think your error is related to Sandboxing on OS X. It is definitely not related to testonly, |
@damienmg is https://github.com/bazelbuild/bazel/wiki/How-to-turn-off-sandboxing accurate? It seems to refer to options applicable for |
If I change my bazel invocation to |
Is this still a release blocker? |
@kchodorow: No sorry. |
@damienmg it's ok - I was able to repro my issue within rules_scala and have PR'd with that failing test bazelbuild/rules_scala#101. No capacity to actually fix right at the moment as I'm involved in our own release cycle. |
Ok only TensorFlow_Serving is left. |
And now TensorFlow_Serving is fixed! Breakage over \o/ |
Creating that bug for tracking my progress toward fixing those projects. /cc @philwo fyi
The text was updated successfully, but these errors were encountered: