Windows: many java tests are failing on Windows

[meteorcloudy]

http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=windows-x86_64/936/consoleFull

There was 1 failure:
1) testGetTargetPathAbsolute(com.google.devtools.build.lib.rules.repository.RepositoryFunctionTest)
java.lang.AssertionError: expected:<A:/b/c> but was:</b/c>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)
    at org.junit.Assert.assertEquals(Assert.java:118)
    at org.junit.Assert.assertEquals(Assert.java:144)

According to some of the error message, my guess the culprit is ca99bb7
//cc @laszlocsomor

[meteorcloudy]

I think maybe we need to adjust the test to adapt this change, right?

[laszlocsomor]

Yes

[laszlocsomor]

One of the failing tests is ArtifactTest.testToDetailString, because we create an artifact at path /a/b/c, which on Windows means A:\b\c.

We've forked some tests already for Windows but I'd rather not do that with even more. So I'll look for a nice, lightweight way to adapt these tests to Windows paths.

[meteorcloudy]

I see, thanks!

[laszlocsomor]

Found the culprit: thanks to ca99bb7, PathFragment on Windows is being smart about MSYS paths, so "/a/b/c" becomes "A:/b/c".

Wait, no, that's not the actual culprit. Sorry :) I keep looking.

[laszlocsomor]

Well, that was indeed the culprit. I have a bugfix, testing then sending out for review ASAP.