Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of include path entries on the command line is unspecified #2143

Closed
lberki opened this issue Nov 28, 2016 · 3 comments
Closed

Order of include path entries on the command line is unspecified #2143

lberki opened this issue Nov 28, 2016 · 3 comments
Assignees
@lberki
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Rules-CPP Issues for C++ rules type: bug

Comments

@lberki
Copy link
Contributor

lberki commented Nov 28, 2016

Apparently, given a certain shape of the dependency graph, it's not specified in which order -I include path entries appear if there are cc_inc_library or cc_library.includes= rules in it.

This should be fixed, because undefined behavior is a bad thing, mmmkay?
@lberki lberki added category: rules > C++ P2 We'll consider working on this in future. (Assignee optional) labels Nov 28, 2016
@hlopko
Copy link
Member

hlopko commented Nov 28, 2016

Definitely needs to be fixed. Will look into that.

@lberki
Copy link
Contributor Author

lberki commented Nov 28, 2016

The simplest would be to figure out what we do now, and if it's sane enough, codify that. For extra points, refactor things so that it's obvious from the implementation. I spent ~10 minutes looking at it and it was very, very far from being obvious.

@hlopko hlopko added team-Rules-CPP Issues for C++ rules and removed category: rules > C++ labels Oct 11, 2018
@hlopko hlopko mentioned this issue Nov 28, 2018
Closed
@hlopko hlopko removed their assignment Dec 6, 2019
@s-sajid-ali s-sajid-ali mentioned this issue Dec 18, 2019
Closed
@jin jin added the type: bug label May 19, 2020
@c-mita c-mita added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Nov 24, 2020
@sgowroji
Copy link
Member

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lberki lberki

Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Rules-CPP Issues for C++ rules type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jin @hlopko @lberki @c-mita @sgowroji