Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.2.0] Add NestedSet<PathFragment>- and Artifact-typed compile build variables #22533

Closed
bazel-io opened this issue May 24, 2024 · 3 comments
Closed

[7.2.0] Add NestedSet<PathFragment>- and Artifact-typed compile build variables #22533

bazel-io opened this issue May 24, 2024 · 3 comments
Milestone
7.2.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #22463
@bazel-io bazel-io added this to the 7.2.0 release blockers milestone May 24, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java
src/main/java/com/google/devtools/build/lib/rules/cpp/CcToolchainVariables.java
src/main/java/com/google/devtools/build/lib/rules/cpp/CompileBuildVariables.java
src/main/java/com/google/devtools/build/lib/rules/cpp/CppLinkstampCompileHelper.java

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

cc: @comius @Wyverald @fmeum @lberki

@fmeum fmeum mentioned this issue May 27, 2024
Merged
@fmeum
Copy link
Collaborator

fmeum commented May 27, 2024

I sent #22557

github-merge-queue bot pushed a commit that referenced this issue May 28, 2024
@fmeum @comius
[7.2.0] Add NestedSet<PathFragment>- and Artifact-typed compile b…
84f4b55 
…uild var… (#22557)

…iables

This change prepares for C++ path mapping, which also needs to map
include directories of generated headers. It may, as a side effect,
reduce memory usage slightly by possibly reusing nested set instances
retained elsewhere.

Work towards #6526

Closes #22463.

PiperOrigin-RevId: 636886343
Change-Id: Ic93d6439a51f37f44bb2ac67d0813c48c0c4a8bd

Fixes #22533

Co-authored-by: Googler <ilist@google.com>
@keertk keertk closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0 release blockers
Development

No branches or pull requests
4 participants
@fmeum @bazel-io @keertk @iancha1992