Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use toolchain env for strip action #22590

Closed
wants to merge 1 commit into from
Closed

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented May 30, 2024

Fixes #14270

@fmeum fmeum requested a review from pzembrod May 30, 2024 11:02
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 30, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented May 30, 2024

@pzembrod The best way to test this would be a starlark analysis test, but those aren't open-source yet. Could you maybe add one to the internal test suite?

@sgowroji sgowroji added the team-Rules-CPP Issues for C++ rules label May 31, 2024
@pzembrod
Copy link
Contributor

@pzembrod The best way to test this would be a starlark analysis test, but those aren't open-source yet. Could you maybe add one to the internal test suite?

Sorry, took me a while to get to this. Will check tomorrow how that could go.

@pzembrod
Copy link
Contributor

@pzembrod The best way to test this would be a starlark analysis test, but those aren't open-source yet. Could you maybe add one to the internal test suite?

Hi Fabian, it turns out they are open sourced already, in bazelbuild/rules_testing; see https://rules-testing.readthedocs.io/en/latest/

Do you want to take a stab at writing a test yourself? I could get to this the week after next at the earliest, possibly later.

@fmeum
Copy link
Collaborator Author

fmeum commented Jun 21, 2024

@pzembrod The library for writing tests (rules_testing) is open-source, but the tests themselves are not. I don't think that there is any Starlark analysis test in Bazel outside the special builtins tests for cc_shared_library.

@pzembrod
Copy link
Contributor

As discussed on Slack, let's merge this now, and I'll open a tracking bug for me so we can see next quarter how to best test this.

@pzembrod pzembrod added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 21, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 26, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 26, 2024

@bazel-io fork 7.3.0

bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jun 26, 2024
Fixes bazelbuild#14270

Closes bazelbuild#22590.

PiperOrigin-RevId: 646928926
Change-Id: I8182bc57fabebbbba441aaa593c72f8c90fa45bb
fmeum added a commit to fmeum/bazel that referenced this pull request Jul 5, 2024
Fixes bazelbuild#14270

Closes bazelbuild#22590.

PiperOrigin-RevId: 646928926
Change-Id: I8182bc57fabebbbba441aaa593c72f8c90fa45bb
github-merge-queue bot pushed a commit that referenced this pull request Jul 10, 2024
Fixes #14270

Closes #22590.

PiperOrigin-RevId: 646928926
Change-Id: I8182bc57fabebbbba441aaa593c72f8c90fa45bb

Commit
9eab47c

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Co-authored-by: Yun Peng <pcloudy@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++: strip action ignores environment passed through toolchain features
3 participants