-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use toolchain env for strip action #22590
Conversation
@pzembrod The best way to test this would be a starlark analysis test, but those aren't open-source yet. Could you maybe add one to the internal test suite? |
Sorry, took me a while to get to this. Will check tomorrow how that could go. |
Hi Fabian, it turns out they are open sourced already, in bazelbuild/rules_testing; see https://rules-testing.readthedocs.io/en/latest/ Do you want to take a stab at writing a test yourself? I could get to this the week after next at the earliest, possibly later. |
@pzembrod The library for writing tests (rules_testing) is open-source, but the tests themselves are not. I don't think that there is any Starlark analysis test in Bazel outside the special builtins tests for |
As discussed on Slack, let's merge this now, and I'll open a tracking bug for me so we can see next quarter how to best test this. |
@bazel-io fork 7.3.0 |
Fixes bazelbuild#14270 Closes bazelbuild#22590. PiperOrigin-RevId: 646928926 Change-Id: I8182bc57fabebbbba441aaa593c72f8c90fa45bb
Fixes bazelbuild#14270 Closes bazelbuild#22590. PiperOrigin-RevId: 646928926 Change-Id: I8182bc57fabebbbba441aaa593c72f8c90fa45bb
Fixes #14270