Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error because of vague JDK version check #2677

Closed
fbartusch opened this issue Mar 14, 2017 · 1 comment
Closed

Compilation error because of vague JDK version check #2677

fbartusch opened this issue Mar 14, 2017 · 1 comment
Labels
P2 We'll consider working on this in future. (Assignee optional) type: bug

Comments

@fbartusch
Copy link

Compilation error because of vague JDK version check

I try to compile bazel-0.4.4 on a cluster. On that cluster I can load a module that sets the environment for Java 1.8. Loading the module sets JAVA_HOME in the following way:
JAVA_HOME= [some_path]/java_jdk/1.8.0u112

wget https://github.com/bazelbuild/bazel/releases/download/0.4.4/bazel-0.4.4-dist.zip
unzip bazel-0.4.4-dist.zip
./compile.sh

./compile.sh aborts with the message:
Building Bazel from scratchscripts/bootstrap/compile.sh: Line 64: [: 8.0u112: Ganzzahliger Ausdruck erwartet
ERROR: JDK version (1.8) is lower than 1.8.0u112, please set $JAVA_HOME.

I think compile.sh tries to take the java version from the directory name and checks if the suffix '8.0u112' is an integer. Maybe one can strip suffixes of the form 'u112' from the string before the integer conversion

@meteorcloudy meteorcloudy added category: misc > bootstrap / installation P2 We'll consider working on this in future. (Assignee optional) type: bug labels Mar 14, 2017
@hvardhanx
Copy link
Contributor

hvardhanx commented Mar 18, 2017

It would be great if anyone could review: https://bazel-review.googlesource.com/#/c/9455/

kchodorow pushed a commit to kchodorow/bazel that referenced this issue Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) type: bug
Projects
None yet
Development

No branches or pull requests

3 participants