Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make javac_opts of java_common.compile expandable #2689

Closed
iirina opened this issue Mar 16, 2017 · 1 comment
Closed

Make javac_opts of java_common.compile expandable #2689

iirina opened this issue Mar 16, 2017 · 1 comment
Labels
good first issue P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Java Issues for Java rules type: feature request

Comments

@iirina
Copy link
Contributor

iirina commented Mar 16, 2017

The javac_opts argument of java_common.compile doesn't accept expandable locations right now. Something like $(GENDIR)/$(location :stub) should be supported (the same as is supported in javacopts of java_library).

@iirina iirina added category: rules > java P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request labels Mar 16, 2017
@iirina iirina self-assigned this Mar 16, 2017
@meisterT meisterT added team-Rules-Java Issues for Java rules and removed category: rules > java labels May 11, 2020
@lberki
Copy link
Contributor

lberki commented Oct 5, 2020

We have the ctx.expand_location() function which does the exact same thing. You can call it from anywhere you can call java_common.compile().

@lberki lberki closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Java Issues for Java rules type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants