Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log spam from MSVC #2726

Closed
laszlocsomor opened this issue Mar 22, 2017 · 5 comments
Closed

Log spam from MSVC #2726

laszlocsomor opened this issue Mar 22, 2017 · 5 comments
Assignees
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) platform: windows type: feature request
Milestone

Comments

@laszlocsomor
Copy link
Contributor

MSVC is very chatty, I see miles and miles of output for building C++ with --cpu=x64_windows_msvc, e.g.:

C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\string(526): note: see declaration of 'std::_Integral_to_string'
        with
        [
            _Ty=unsigned int
        ]
(...same or similar things hundreds of times...)

third_party/protobuf/3.0.0/src\google/protobuf/arena.h(623): note: see declaration of 'google::protobuf::Arena::CreateMaybeMessage'
        with
        [
            T=google::protobuf::FieldDescriptorProto
        ]
(...same or similar things hundreds of times...)
@laszlocsomor laszlocsomor added platform: windows P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request labels Mar 22, 2017
@meteorcloudy
Copy link
Member

The error message is incomplete, we should not filter them in msvc_tools.py, but that would only increase the size of output.
But try adding --copt=/w --host_copt=/w, the world will be quiet immediately.

@laszlocsomor
Copy link
Contributor Author

laszlocsomor commented Mar 22, 2017

cool, i'll try that tomorrow, thanks!
note that these messages are not errors but notes; for whatever reason msvc thinks it's important to make a note about each and every template instantiation, it seems

kchodorow pushed a commit to kchodorow/bazel that referenced this issue Mar 28, 2017
Fixed: bazelbuild#2666
See: bazelbuild#2726

RELNOTES: Windows MSVC wrappers: Not filtering warning messages anymore, use --copt=-w and --host_copt=-w to suppress them.

PiperOrigin-RevId: 151422047
bazel-io pushed a commit that referenced this issue Mar 28, 2017
Fixed: #2666
See: #2726

RELNOTES: Windows MSVC wrappers: Not filtering warning messages anymore, use --copt=-w and --host_copt=-w to suppress them.

--
PiperOrigin-RevId: 151422047
MOS_MIGRATED_REVID=151422047
@dslomov dslomov added this to the 0.6 milestone Apr 4, 2017
@dslomov
Copy link
Contributor

dslomov commented Jul 24, 2017

@meteorcloudy isn't this fixed?

@dslomov
Copy link
Contributor

dslomov commented Jul 24, 2017

(if not, moving to 0.7)

@dslomov dslomov modified the milestones: 0.7, 0.6 Jul 24, 2017
@meteorcloudy
Copy link
Member

This is fixed, since we are not using wrapper-script, we are also not filtering any warning messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) platform: windows type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants