common JDKs don't support params files

[chaoren]

Please provide the following information. The more we know about your system and use case, the more easily and likely we can help.

Description of the problem / feature request / question:

If asking a question or requesting a feature, also tell us about the underlying problem you're trying to solve.

The scala rules is borrowing the java_stub_template from the java rules, and it seems like this line doesn't actually work.

If possible, provide a minimal example to reproduce the problem:

$ ./bazel-bin/foo.runfiles/local_jdk/bin/java -classpath ./bazel-bin/foo.runfiles/__main__/foo.jar Foo
Hello world!
$ ./bazel-bin/foo.runfiles/local_jdk/bin/java -classpath @<(echo ./bazel-bin/foo.runfiles/__main__/foo.jar) Foo
Error: Could not find or load main class Foo

[laszlocsomor]

@chaoren : What platform did you try on?

[ittaiz]

OS X at least

…

On Mon, 29 May 2017 at 11:37 László Csomor ***@***.***> wrote: @chaoren <https://github.com/chaoren> : What platform did you try on? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3069 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIF6AHl58A-bgFeZnr5LdD-OfNIy3Kks5r-oPKgaJpZM4Nor6d> .

[laszlocsomor]

I managed to repro this. Apparently neither OpenJDK for MacOS nor Zulu JRE (that we bundle Bazel 0.5.0 with) support parameter file syntax (i.e. java -cp @paramfile classname).

Repro:

cd /tmp

echo > Foo.java <<EOF
public class Foo { public static void main(String[] args) { System.out.println("Hello world!"); } }
EOF

javac Foo.java

Then this works:

$ java -cp /tmp Foo
Hello world!

But this doesn't:

$ echo /tmp > /tmp/cp.txt && java -cp @/tmp/cp.txt Foo
Error: Could not find or load main class Foo

Here's my Java:

$ java -version
java version "1.8.0_102"
Java(TM) SE Runtime Environment (build 1.8.0_102-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.102-b14, mixed mode)

[laszlocsomor]

This only affects users with very long classpaths (>120K) so I'm prioritizing it as P2.
We already work around this issue on Windows, so I'll just use that code path.

[laszlocsomor]

Just to clarify: process substitution (the @<(echo $CLASSPATH) thingy) works fine on MacOS (it creates a pipe as /dev/fd/63).

[ittaiz]

Do you know if oracle jdk works?

…

On Mon, 29 May 2017 at 16:00 László Csomor ***@***.***> wrote: Just to clarify: process substitution (the @<(echo $CLASSPATH)) works fine on MacOS (it creates a named pipe as /dev/fd/63). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3069 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIF_o0TM0DmgUs5SnsHPR42smxRzmCks5r-sFfgaJpZM4Nor6d> .

[laszlocsomor]

@ittaiz : It doesn't, I just tried.

[laszlocsomor]

Unfortunately Bazel doesn't pick up the fixed java_stub_template from the workspace. The template is compiled into Bazel instead. So to see the effects of the bugfix, you must rebuild Bazel from head and use that binary, or wait for the next release.

[chaoren]

Won't this line cause a problem outside of cygwin?

bazel/src/main/java/com/google/devtools/build/lib/bazel/rules/java/java_stub_template.txt

Line 303 in 102ce6d

MANIFEST_JAR_FILE=$(cygpath --windows "$MANIFEST_JAR_FILE")

Can we please have a test for this?

[laszlocsomor]

Oops, you're right, good catch! I forgot to remove that line. Yes, this needs a test, I'll add one.