-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows, *_binary launcher: should work when rule is in an external repo #3491
Comments
Release-critical for 0.5.4 / 0.6.0. |
We only use the launcher for sh_binary, right? |
@meteorcloudy already fixed this with a oneliner |
Yet you have a good point; the launcher may have other bugs we don't know about. |
@laszlocsomor That's a good idea, and it shouldn't be too hard to do this. |
If this is enabled, Bazel will build a Windows native exe binary launcher for sh_binary, in the future this flag will also apply to py_binary and java_binary. By default, it's turned ON, set --windows_exe_launcher=0 to turn it off. Fix #3491 Change-Id: Ic55bff745670446e585e3cc62af9dc6561527d4f PiperOrigin-RevId: 164234552
Fix #3491 RELNOTES: None PiperOrigin-RevId: 164089270
If this is enabled, Bazel will build a Windows native exe binary launcher for sh_binary, in the future this flag will also apply to py_binary and java_binary. By default, it's turned ON, set --windows_exe_launcher=0 to turn it off. Fix #3491 Change-Id: Ic55bff745670446e585e3cc62af9dc6561527d4f PiperOrigin-RevId: 164234552
Fix #3491 RELNOTES: None PiperOrigin-RevId: 164089270
If this is enabled, Bazel will build a Windows native exe binary launcher for sh_binary, in the future this flag will also apply to py_binary and java_binary. By default, it's turned ON, set --windows_exe_launcher=0 to turn it off. Fix #3491 Change-Id: Ic55bff745670446e585e3cc62af9dc6561527d4f PiperOrigin-RevId: 164234552
Fix #3491 RELNOTES: None PiperOrigin-RevId: 164089270
If this is enabled, Bazel will build a Windows native exe binary launcher for sh_binary, in the future this flag will also apply to py_binary and java_binary. By default, it's turned ON, set --windows_exe_launcher=0 to turn it off. Fix #3491 Change-Id: Ic55bff745670446e585e3cc62af9dc6561527d4f PiperOrigin-RevId: 164234552
Fix #3491 RELNOTES: None PiperOrigin-RevId: 164089270
If this is enabled, Bazel will build a Windows native exe binary launcher for sh_binary, in the future this flag will also apply to py_binary and java_binary. By default, it's turned ON, set --windows_exe_launcher=0 to turn it off. Fix #3491 Change-Id: Ic55bff745670446e585e3cc62af9dc6561527d4f PiperOrigin-RevId: 164234552
Fix bazelbuild/bazel#3491 RELNOTES: None PiperOrigin-RevId: 164089270
If a {sh,py,java}_binary rule is in an external repository (e.g.
@bazel_tools//tools/android:zip_manifest_creator
), its exe launcher doesn't work because, in the case of sh_binary for example, thebash_main_path
variable's value is computed from runfiles-relative path, which is "../build_tools/android/tools/zip_manifest_creator.sh" (relative to the execroot), which is not a valid entry in the manifest file.Instead the rule should substitute the main file's exec path into
bash_main_file
, because that's the path in the manifest.The text was updated successfully, but these errors were encountered: