Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows, *_launcher: should pass the RUNFILES and RUNFILES_MANIFEST_FILE envvars to the script #3492

Closed
laszlocsomor opened this issue Aug 2, 2017 · 1 comment
Closed

Windows, *_launcher: should pass the RUNFILES and RUNFILES_MANIFEST_FILE envvars to the script #3492

laszlocsomor opened this issue Aug 2, 2017 · 1 comment
Assignees
@laszlocsomor
Labels
P1 I'll work on this now. (Assignee required) platform: windows type: bug
Milestone
0.6

Comments

@laszlocsomor
Copy link
Contributor

The exe launcher for {sh,py,java}_binary rules set the RUNFILES and RUNFILES_MANIFEST_FILE envvars in the launched script's environment, otherwise they can't find their runfiles.
@laszlocsomor laszlocsomor added platform: windows P1 I'll work on this now. (Assignee required) type: bug Release blocker labels Aug 2, 2017
@laszlocsomor
Copy link
Contributor Author

Release-critical for 0.5.4 / 0.6.0.

@dslomov dslomov modified the milestones: 0.6, 0.5 Aug 2, 2017
@laszlocsomor laszlocsomor modified the milestones: 0.6, 0.5 Aug 3, 2017
buchgr pushed a commit that referenced this issue Aug 7, 2017
@laszlocsomor @buchgr
Windows, sh_bin. launcher: export runfiles envvars
83e3db7 
Fix the exe launcher of sh_binary rules to export
the RUNFILES_MANIFEST_ONLY and
RUNFILES_MANIFEST_FILE environment variables.

Fixes #3492

Change-Id: I8507565f44c8b59f8218570306375cc083a41e03
PiperOrigin-RevId: 164095286
buchgr pushed a commit that referenced this issue Aug 11, 2017
@laszlocsomor @buchgr
Windows, sh_bin. launcher: export runfiles envvars
8e1c776 
Fix the exe launcher of sh_binary rules to export
the RUNFILES_MANIFEST_ONLY and
RUNFILES_MANIFEST_FILE environment variables.

Fixes #3492

Change-Id: I8507565f44c8b59f8218570306375cc083a41e03
PiperOrigin-RevId: 164095286
buchgr pushed a commit that referenced this issue Aug 21, 2017
@laszlocsomor @buchgr
Windows, sh_bin. launcher: export runfiles envvars
ef65389 
Fix the exe launcher of sh_binary rules to export
the RUNFILES_MANIFEST_ONLY and
RUNFILES_MANIFEST_FILE environment variables.

Fixes #3492

Change-Id: I8507565f44c8b59f8218570306375cc083a41e03
PiperOrigin-RevId: 164095286
buchgr pushed a commit that referenced this issue Aug 22, 2017
@laszlocsomor @buchgr
Windows, sh_bin. launcher: export runfiles envvars
a76d2e4 
Fix the exe launcher of sh_binary rules to export
the RUNFILES_MANIFEST_ONLY and
RUNFILES_MANIFEST_FILE environment variables.

Fixes #3492

Change-Id: I8507565f44c8b59f8218570306375cc083a41e03
PiperOrigin-RevId: 164095286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laszlocsomor laszlocsomor

Labels
P1 I'll work on this now. (Assignee required) platform: windows type: bug
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
3 participants
@meteorcloudy @dslomov @laszlocsomor