New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable aapt2 by default #4103

Open
aj-michael opened this Issue Nov 16, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@aj-michael
Copy link
Contributor

aj-michael commented Nov 16, 2017

It works internally and is now the default in gradle:

https://developer.android.com/studio/build/gradle-plugin-3-0-0.html

@aj-michael aj-michael self-assigned this Nov 16, 2017

bazel-io pushed a commit that referenced this issue Dec 5, 2017

Add aapt2 to the filegroup of integration test dependencies.
This will allow us to write a bazel integration test for --android_aapt=aapt2.

Necessary for #4103.

RELNOTES: None
PiperOrigin-RevId: 177980382

duggelz pushed a commit to duggelz/bazel that referenced this issue Dec 15, 2017

Add aapt2 to the filegroup of integration test dependencies.
This will allow us to write a bazel integration test for --android_aapt=aapt2.

Necessary for bazelbuild#4103.

RELNOTES: None
PiperOrigin-RevId: 177980382

@jin jin assigned jin and unassigned aj-michael Jun 8, 2018

@jin

This comment has been minimized.

Copy link
Member

jin commented Jul 20, 2018

aapt2 will be fully functional in the next release (0.17.0), and we can schedule to enable it by default for 0.18.0.

@jin

This comment has been minimized.

Copy link
Member

jin commented Aug 14, 2018

To take note: mobile-install v1 doesn't yet work with aapt2 #5799

@jin jin referenced this issue Nov 30, 2018

Closed

mobile-install v1 umbrella bug #6814

3 of 3 tasks complete
@jin

This comment has been minimized.

Copy link
Member

jin commented Dec 7, 2018

#5799 is closed, we can proceed with the making aapt2 the default for Bazel.

@jin jin added P1 and removed P2 labels Dec 12, 2018

bazel-io pushed a commit that referenced this issue Dec 14, 2018

Add --incompatible_use_aapt2_by_default incompatible change (IC) flag…
… for enabling aapt2 by default in Bazel.

FR Ref: #4103
IC Ref: #6907

RELNOTES: New incompatible change flag for defaulting to aapt2 in Android builds: `--incompatible_use_aapt2_by_default`. To build with aapt2 today, pass the flag `--incompatible_use_aapt2_by_default=true` or `--android_aapt=aapt2`, or set the `aapt_version`  to `aapt2` on your `android_binary` or `android_local_test` target.
PiperOrigin-RevId: 225593174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment