Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable aapt2 by default #4103

Closed
aj-michael opened this issue Nov 16, 2017 · 3 comments
Closed

Enable aapt2 by default #4103

aj-michael opened this issue Nov 16, 2017 · 3 comments
Assignees
Labels
P1 I'll work on this now. (Assignee required) team-Android Issues for Android team type: feature request

Comments

@aj-michael
Copy link
Contributor

It works internally and is now the default in gradle:

https://developer.android.com/studio/build/gradle-plugin-3-0-0.html

@aj-michael aj-michael added category: rules > android P2 We'll consider working on this in future. (Assignee optional) labels Nov 16, 2017
@aj-michael aj-michael self-assigned this Nov 16, 2017
bazel-io pushed a commit that referenced this issue Dec 5, 2017
This will allow us to write a bazel integration test for --android_aapt=aapt2.

Necessary for #4103.

RELNOTES: None
PiperOrigin-RevId: 177980382
@jin jin assigned jin and unassigned aj-michael Jun 8, 2018
@jin
Copy link
Member

jin commented Jul 20, 2018

aapt2 will be fully functional in the next release (0.17.0), and we can schedule to enable it by default for 0.18.0.

@jin jin added team-Android Issues for Android team and removed category: rules > android labels Aug 11, 2018
@jin
Copy link
Member

jin commented Aug 14, 2018

To take note: mobile-install v1 doesn't yet work with aapt2 #5799

@jin
Copy link
Member

jin commented Dec 7, 2018

#5799 is closed, we can proceed with the making aapt2 the default for Bazel.

@jin jin added P1 I'll work on this now. (Assignee required) and removed P2 We'll consider working on this in future. (Assignee optional) labels Dec 12, 2018
bazel-io pushed a commit that referenced this issue Dec 14, 2018
… for enabling aapt2 by default in Bazel.

FR Ref: #4103
IC Ref: #6907

RELNOTES: New incompatible change flag for defaulting to aapt2 in Android builds: `--incompatible_use_aapt2_by_default`. To build with aapt2 today, pass the flag `--incompatible_use_aapt2_by_default=true` or `--android_aapt=aapt2`, or set the `aapt_version`  to `aapt2` on your `android_binary` or `android_local_test` target.
PiperOrigin-RevId: 225593174
bazel-io pushed a commit that referenced this issue Aug 7, 2019
*** Reason for rollback ***

Broke Android build on Windows
#9102

*** Original change description ***

Default Bazel to use aapt2 and fix native tests to use aapt2.

This CL sets --incompatible_use_aapt2_by_default=true and --android_aapt=aapt2. It also adds aapt2 to the mock SDK for Android analysis and integration tests.

For the tests that assume and depend on AAPT, we explicitly pin them to use AAPT.

Fixes #6907
Fixes #4103

RELNOTES: Bazel Android builds now use aapt2 by default. To revert to aapt, set `--an...

***

ROLLBACK_OF=261424350

RELNOTES: None
PiperOrigin-RevId: 262099198
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
…g for enabling aapt2 by default in Bazel.

    FR Ref: bazelbuild/bazel#4103
    IC Ref: bazelbuild/bazel#6907

    RELNOTES: New incompatible change flag for defaulting to aapt2 in Android builds: `--incompatible_use_aapt2_by_default`. To build with aapt2 today, pass the flag `--incompatible_use_aapt2_by_default=true` or `--android_aapt=aapt2`, or set the `aapt_version`  to `aapt2` on your `android_binary` or `android_local_test` target.
    PiperOrigin-RevId: 225593174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) team-Android Issues for Android team type: feature request
Projects
None yet
Development

No branches or pull requests

2 participants