-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tag for tests that only pass on Windows #4230
Comments
We already have such tests, and what I usually do is using a Example: Lines 59 to 64 in 9ac1f28
|
Thanks for the tip, that sounds good. I'll close this issue since we don't intend to add the tags as I described them. I mailed https://bazel-review.googlesource.com/c/bazel/+/25250 to add selects to def_parser_test. |
See #4230. Change-Id: Ia0125d76eb47226ad8e09829e559d636f064b369 RELNOTES: None
I noticed that //third_party/def_parser:def_parser_test only works on Windows. In fact, it does not build on mac or linux. We use the "no_windows" tag to mark tests that dont work on Windows. Perhaps we should have a corresponding tag to indicate tests that only work on Windows?
This is an issue for our internal CI system which uses bazel query to determine which tests to run on mac, but currently there is no way to filter out Windows-only tests.
The text was updated successfully, but these errors were encountered: