CI, bazel-watcher: failing with bazel 0.9.0 rc2

[laszlocsomor]

Blocking: #3773

Log: https://ci.bazel.io/job/Global/job/bazel-watcher/311/console

Ran as part of Bazel 0.9.0 rc2 test: https://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/bazel/job/release/533/Downstream_projects/

Binaries: https://releases.bazel.build/0.9.0/rc2/index.html

Example log:

[node=darwin-x86_64] ERROR: /Users/ci/workspace/Global/bazel-watcher-node=darwin-x86_64/WORKSPACE:69:1: Cannot redefine repository after any load statement in the WORKSPACE file (for repository 'com_github_golang_protobuf')
[node=darwin-x86_64] ERROR: Error evaluating WORKSPACE file
[node=darwin-x86_64] ERROR: error loading package 'external': Package 'external' contains errors
[node=darwin-x86_64] INFO: Elapsed time: 0.961s
[node=darwin-x86_64] FAILED: Build did NOT complete successfully (0 packages loaded)
[node=darwin-x86_64] FAILED: Build did NOT complete successfully (0 packages loaded)

[laszlocsomor]

TODO:

• repro the failure with Bazel 0.9.0 rc2
• try to repro with Bazel 0.8.1, see if it's failing with that too
  • if failing, then mark as non-blocker for Release - December 2017 - Target RC date: 2017-12-01 - name: 0.9.0 #3773
  • if not failing, bisect commits to find culprit

[buchgr]

I can confirm that it works with 0.8.1 and fails with 0.9.0 rc2. Bisecting.

[buchgr]

git bisect tells me that 337f19c is the offending commit.

[buchgr]

I reverted the commit on my local branch and can confirm that bazel-watcher works without the commit.

[laszlocsomor]

See #3773 (comment)
Damien apparently already expected that change to cause problems. As I understand it, he planned to revert it anyway.

Jakob, can you revert that commit please?

[buchgr]

Yes sir!