Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support portrait mode for documentation #4262

Closed
marcohu opened this issue Dec 10, 2017 · 3 comments
Closed

Support portrait mode for documentation #4262

marcohu opened this issue Dec 10, 2017 · 3 comments
Assignees
@jin
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug type: documentation (cleanup)

Comments

@marcohu
Copy link
Contributor

marcohu commented Dec 10, 2017 •
edited

I'm using my monitors in portrait mode. Each provides 1200px horizontally. Unfortunately the Bazel online documentation (https:docs.bazel.build) does not play nice with this setup.

The actual content is displayed below the vertical navigation bar which makes navigation so much harder (see attached screenshot).

If I make the window only a few pixels wider, the page displays as expected, but this defeats the purpose of the tiling window manager I use.

It's possible to fix the issue on the client side with tools like Stylish, but I would appreciate if such action wouldn't be necessary.

1200px
@marcohu
Copy link
Contributor Author

marcohu commented Dec 10, 2017

If I increase the window width by 11px, the content does not reflow. Given that there are very generous white space margins, I would suggest that these are simply made smaller if the horizontal space is limited.

jin added a commit to jin/bazel that referenced this issue Dec 10, 2017
@jin
Fixed documentation navigation bar/content layout awkwardness.
3227ef8 
A specific browser view width range causes the navigation bar to be stacked on top of the documentation content, therefore requiring a bit of scrolling to get to it. 

This fix changes col-lg-* to col-md-*, which changes the width threshold at which the columns re-layout.

Tested locally on Chrome & Safari.

Fixes bazelbuild#4262
@jin jin mentioned this issue Dec 10, 2017
Closed
@jin
Copy link
Member

jin commented Dec 10, 2017

Sent out a fix in #4263

@marcohu
Copy link
Contributor Author

marcohu commented Dec 10, 2017

That will do. Thanks very much for your very quick action!

@laszlocsomor laszlocsomor added P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug type: documentation (cleanup) labels Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jin jin

Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug type: documentation (cleanup)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed documentation navigation bar/content layout awkwardness. jin/bazel
3 participants
@jin @marcohu @laszlocsomor