Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc for @bazel_tools #4301

Open
olafure opened this issue Dec 14, 2017 · 16 comments
Open

Doc for @bazel_tools #4301

olafure opened this issue Dec 14, 2017 · 16 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: documentation (cleanup)

Comments

@olafure
Copy link

olafure commented Dec 14, 2017

Bazel documentation is missing an explanation the "@bazel_tools" built in repository.

@aehlig aehlig added P2 We'll consider working on this in future. (Assignee optional) type: documentation (cleanup) labels Dec 15, 2017
@jin jin added the team-Bazel General Bazel product/strategy issues label Feb 20, 2019
@panzhongxian
Copy link
Contributor

What's the link of doc for @bazel_tools ? thx.

@dslomov dslomov added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged and removed team-Bazel General Bazel product/strategy issues P2 We'll consider working on this in future. (Assignee optional) labels Jul 23, 2019
@dslomov
Copy link
Contributor

dslomov commented Jul 23, 2019

We did add documentation for http_archive etc; shall we add more?

@laurentlb
Copy link
Contributor

The documentation doesn't say what is @bazel_tools, so yes.
We should mention it's a magic repository that's part of Bazel binary.

@laurentlb laurentlb added P2 We'll consider working on this in future. (Assignee optional) and removed bazel 1.0 untriaged labels Jul 24, 2019
@ghost
Copy link

ghost commented Mar 9, 2020

External contributors would benefit from guidelines for what (not) to do when adding to bazel_tools (see #8738 (comment)).

EDIT: Okay, so consensus seems that adding to bazel_tools is a no-go. (Unsure of implications for #8738, but that discussion should stay with that issue.)

@laurentlb
Copy link
Contributor

I think it's better if we don't add anything to @bazel_tools.
Most files should live outside the Bazel binary.

@jin
Copy link
Member

jin commented Mar 9, 2020

+1 we should be removing targets from @bazel_tools as much as possible.

cc @alandonovan who ran into issues with the JDK / Java rules side of the embedded repository recently.

@alandonovan
Copy link
Contributor

alandonovan commented Mar 9, 2020

I recently added a "jni" target to @bazel_tools//java/jdk, and was struck that (a) this repo's public API is essentially undocumented, and (b) that declarations added to it take a full Bazel release before they can be used, which imposes a surprisingly subtle obstacle to evolution.

I agree we should get rid of this repo. Although there may still be a need for a mechanism to expose built-in symbols to certain rule sets (Java, for example) owned by the Bazel team, exposing these symbols directly to the whole world is a liability.

@blais
Copy link

blais commented May 28, 2020

I just encountered this @bazel_tools and got surprised by its existence as well.

@nickgeorge
Copy link

nickgeorge commented Jun 8, 2020

+1, as an internal google user, this was still very surprising to me that there is a magic @-target, that is a requirement to know about for things as basic as http_archive. This needs to be documented well.

@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@dzintars
Copy link

dzintars commented Nov 27, 2020

Not sure is it important there, but i came across this error/warning when run ibazel on Linux without any relations to apple ecosystem:

iBazel [3:29PM]: Querying for files to watch...
Loading: 0 packages loaded
ERROR: /home/dzintars/.cache/bazel/_bazel_dzintars/73eb78004b7f7dbbf7672ded04d50930/external/bazel_tools/tools/osx/BUILD:80:19: every rule of type xcode_config_alias implicitly depends upon the target '@bazel_tools//tools/objc:host_xcodes', but this target could not be found because of: no such target '@bazel_tools//tools/objc:host_xcodes': target 'host_xcodes' not declared in package 'tools/objc' defined by /home/dzintars/.cache/bazel/_bazel_dzintars/73eb78004b7f7dbbf7672ded04d50930/external/bazel_tools/tools/objc/BUILD.bazel
ERROR: /home/dzintars/.cache/bazel/_bazel_dzintars/73eb78004b7f7dbbf7672ded04d50930/external/bazel_tools/tools/osx/BUILD:80:19: every rule of type xcode_config_alias implicitly depends upon the target '@bazel_tools//tools/objc:host_xcodes', but this target could not be found because of: no such target '@bazel_tools//tools/objc:host_xcodes': target 'host_xcodes' not declared in package 'tools/objc' defined by /home/dzintars/.cache/bazel/_bazel_dzintars/73eb78004b7f7dbbf7672ded04d50930/external/bazel_tools/tools/objc/BUILD.bazel
ERROR: Evaluation of subquery "deps(set(//platform/web/shell/server))" failed (did you want to use --keep_going?): errors were encountered while computing transitive closure
Loading: 1 packages loaded
Loading: 1 packages loaded
iBazel [3:29PM]: Bazel query failed: exit status 7

So i am looking forward to resolve this "warning".

@philwo philwo added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Dec 8, 2020
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
@stabai
Copy link

stabai commented Jun 6, 2022

I feel like the documentation here (which is the best documentation I've found) should have more detailed explanation, and should also be included on every page that talks about built-in rules, like the BUILD encyclopedia.

Based on discussion here, it seems that this list is only expected to shrink in the future, which is good. Skylib is also not obvious to find, and it should be. I see the wisdom in that being imported separately, but it's still pretty core functionality. But bazel_tools being in this weird built-in but not native state is incredibly confusing.

@devesh-bedrock
Copy link

Does anyone know where I can find details on @bazel_tools//platforms:target_platform and @bazel_tools//platforms:host_platform?

+1 to improving to documentation on everything inside @bazel_tools.

@justonelov
Copy link

justonelov commented Oct 11, 2022 via email

Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Mar 17, 2024
@Jasha10
Copy link

Jasha10 commented Mar 17, 2024

It will be closed in the next 90 days unless any other activity occurs.

~activity~

@github-actions github-actions bot removed the stale Issues or PRs that are stale (no activity for 30 days) label Mar 18, 2024
@korjek
Copy link

korjek commented Jun 3, 2024

still active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: documentation (cleanup)
Projects
None yet
Development

No branches or pull requests